[ignite-3] branch main updated: IGNITE-18894 Cleanup resolved TODOs (#1714)

[apkhmv]

This is an automated email from the ASF dual-hosted git repository.

apkhmv pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git


The following commit(s) were added to refs/heads/main by this push:
     new 361d731b0a IGNITE-18894 Cleanup resolved TODOs (#1714)
361d731b0a is described below

commit 361d731b0a148fe1c7cbe055f9b0a97864478412
Author: Vadim Pakhnushev <8614891+valep...@users.noreply.github.com>
AuthorDate: Fri Feb 24 13:53:30 2023 +0300

    IGNITE-18894 Cleanup resolved TODOs (#1714)
---
 .../apache/ignite/internal/cli/core/flow/builder/FlowBuilderImpl.java   | 2 +-
 .../org/apache/ignite/internal/cli/core/repl/executor/ReplExecutor.java | 2 +-
 .../main/java/org/apache/ignite/internal/schema/row/RowAssembler.java   | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/flow/builder/FlowBuilderImpl.java
 
b/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/flow/builder/FlowBuilderImpl.java
index b4cdc8bc20..b2889c5241 100644
--- 
a/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/flow/builder/FlowBuilderImpl.java
+++ 
b/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/flow/builder/FlowBuilderImpl.java
@@ -164,7 +164,7 @@ public class FlowBuilderImpl<I, O> implements 
FlowBuilder<I, O> {
      */
     private Flowable<O> printResult(Flowable<O> input, Function<Class<O>, 
Decorator<O, TerminalOutput>> decoratorProvider) {
         if (input.hasResult()) {
-            // Workaround for the 
https://issues.apache.org/jira/browse/IGNITE-17346
+            // Workaround for the scroll truncation issue in windows terminal
             // This will turn the tailtips off before printing
             CommandLineContextProvider.print(() -> {
                 String out = 
decoratorProvider.apply(input.type()).decorate(input.value()).toTerminalString();
diff --git 
a/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/repl/executor/ReplExecutor.java
 
b/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/repl/executor/ReplExecutor.java
index 58b5409732..2c57c10c7d 100644
--- 
a/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/repl/executor/ReplExecutor.java
+++ 
b/modules/cli/src/main/java/org/apache/ignite/internal/cli/core/repl/executor/ReplExecutor.java
@@ -90,7 +90,7 @@ public class ReplExecutor {
         TailTipWidgets widgets = new TailTipWidgets(reader, 
registry::commandDescription, 5,
                 TailTipWidgets.TipType.COMPLETER);
         widgets.enable();
-        // Workaround for the 
https://issues.apache.org/jira/browse/IGNITE-17346
+        // Workaround for the scroll truncation issue in windows terminal
         // Turn off tailtip widgets before printing to the output
         CommandLineContextProvider.setPrintWrapper(printer -> {
             widgets.disable();
diff --git 
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/row/RowAssembler.java
 
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/row/RowAssembler.java
index f6e16ccd95..6c4e4e05df 100644
--- 
a/modules/schema/src/main/java/org/apache/ignite/internal/schema/row/RowAssembler.java
+++ 
b/modules/schema/src/main/java/org/apache/ignite/internal/schema/row/RowAssembler.java
@@ -664,7 +664,6 @@ public class RowAssembler {
      * @return Created {@link BinaryRow}.
      */
     public BinaryRow build() {
-        //TODO reuse buffer https://issues.apache.org/jira/browse/IGNITE-18697
         boolean hasValue = flush();
 
         ByteBuffer tupleBuffer = builder.build();