This is an automated email from the ASF dual-hosted git repository. jooger pushed a commit to branch ignite-19065 in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 34ed5833f5628d13ef6665a5dedfd17cd515958d Author: Yury Gerzhedovich <[email protected]> AuthorDate: Thu May 16 15:24:55 2024 +0300 IGNITE-19065: add test to implicit insert null into not null column --- .../apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java | 5 +++++ .../src/integrationTest/sql/types/char/test_char_length.test | 6 ------ .../ignite/internal/sql/engine/planner/LimitOffsetPlannerTest.java | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java index ee98b8a91b..072abe1d24 100644 --- a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java +++ b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java @@ -92,6 +92,11 @@ public abstract class ItNotNullConstraintTest extends ClusterPerClassIntegration "Column 'INT_COL' does not allow NULLs", () -> runSql("INSERT INTO t1 SELECT 1, NULL")); + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> runSql("INSERT INTO t1 (id) VALUES(1)")); + // UPDATE sql("INSERT INTO t1 VALUES(1, 42)"); diff --git a/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test b/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test index 243dcf284b..704402d77c 100644 --- a/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test +++ b/modules/sql-engine/src/integrationTest/sql/types/char/test_char_length.test @@ -16,8 +16,6 @@ statement ok CREATE TABLE t_default(c1 CHAR); # If <length> is omitted, then a <length> of 1 (one) is implicit. -skipif ignite3 -# https://issues.apache.org/jira/browse/IGNITE-18492 statement error INSERT INTO t_default VALUES('12'); @@ -33,8 +31,6 @@ statement ok CREATE TABLE t_three (c1 CHAR(3), c2 CHARACTER(3)); # MUST FAIL due to length -skipif ignite3 -# https://issues.apache.org/jira/browse/IGNITE-18492 statement error INSERT INTO t_three VALUES('1', '4444'); @@ -45,8 +41,6 @@ statement ok DELETE FROM t_three WHERE c2 = '444'; # MUST FAIL due to length -skipif ignite3 -# https://issues.apache.org/jira/browse/IGNITE-18492 statement error INSERT INTO t_three VALUES('1234', '444'); diff --git a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/LimitOffsetPlannerTest.java b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/LimitOffsetPlannerTest.java index 2b6c802917..5a0a82b957 100644 --- a/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/LimitOffsetPlannerTest.java +++ b/modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/LimitOffsetPlannerTest.java @@ -196,7 +196,7 @@ public class LimitOffsetPlannerTest extends AbstractPlannerTest { @Test public void testNestedOffset() throws Exception { // Tests for planner for limit/sort in nested subqueries - // See bug https://issues.apache.org/jira/browse/IGNITE-21946 + // See bug https://issues.apache.org/jira/browse/IGNITE-22204 TableBuilder builder = TestBuilders.table() .name("TEST")
