This is an automated email from the ASF dual-hosted git repository.
jooger pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new b78fab2d05 IGNITE-22256: remove incorrect tests in
ItKvKeyColumnPositionTest. (#3778)
b78fab2d05 is described below
commit b78fab2d05b6032bac79cfe953a986dc1003f6e8
Author: Max Zhuravkov <[email protected]>
AuthorDate: Thu May 16 16:36:25 2024 +0300
IGNITE-22256: remove incorrect tests in ItKvKeyColumnPositionTest. (#3778)
---
.../sql/api/ItKvKeyColumnPositionTest.java | 31 ----------------------
1 file changed, 31 deletions(-)
diff --git
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItKvKeyColumnPositionTest.java
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItKvKeyColumnPositionTest.java
index ec9d70b4b3..8c4c0d6bc7 100644
---
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItKvKeyColumnPositionTest.java
+++
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItKvKeyColumnPositionTest.java
@@ -33,13 +33,11 @@ import org.apache.ignite.internal.schema.row.Row;
import org.apache.ignite.internal.sql.BaseSqlIntegrationTest;
import org.apache.ignite.internal.tostring.IgniteToStringInclude;
import org.apache.ignite.internal.tostring.S;
-import org.apache.ignite.lang.NullableValue;
import org.apache.ignite.table.KeyValueView;
import org.apache.ignite.table.manager.IgniteTables;
import org.apache.ignite.table.mapper.Mapper;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Named;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
@@ -180,35 +178,6 @@ public class ItKvKeyColumnPositionTest extends
BaseSqlIntegrationTest {
}
}
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21836";)
- @ParameterizedTest
- @MethodSource("nullableKvsSimple")
- public void testNotNullableGetSimple(KeyValueView<String, IntBoolDate>
kvView) {
- String key = String.valueOf(ID_NUM.incrementAndGet());
- kvView.put(null, key, null);
-
- NullableValue<IntBoolDate> nullable = kvView.getNullable(null, key);
- assertNull(nullable.get());
- }
-
- private List<Arguments> nullableKvsSimple() {
- return List.of(
- Arguments.of(Named.named("server", serverSimpleValKey)),
- Arguments.of(Named.named("client", clientSimpleKeyVal))
- );
- }
-
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-21836";)
- @ParameterizedTest
- @MethodSource("complexKeyKvs")
- public void testNotNullableGetComplex(KeyValueView<IntString, BoolInt>
kvView) {
- IntString key = newKey();
- kvView.put(null, key, null);
-
- NullableValue<BoolInt> nullable = kvView.getNullable(null, key);
- assertNull(nullable.get());
- }
-
@ParameterizedTest
@MethodSource("simpleKeyKvs")
public void testSimplePutGet(KeyValueView<String, IntBoolDate> kvView) {
