(ignite-3) branch main updated: IGNITE-21968 Sql. Extend test coverage for SQL E141-07(Basic integrity constraints. Column defaults) (#3919)

[ppa]

This is an automated email from the ASF dual-hosted git repository.

ppa pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git


The following commit(s) were added to refs/heads/main by this push:
     new e5d6858810 IGNITE-21968 Sql. Extend test coverage for SQL 
E141-07(Basic integrity constraints. Column defaults) (#3919)
e5d6858810 is described below

commit e5d6858810b21230e73431ec20b8c0a1376668ec
Author: Max Zhuravkov <shh...@gmail.com>
AuthorDate: Fri Jun 14 12:30:01 2024 +0400

    IGNITE-21968 Sql. Extend test coverage for SQL E141-07(Basic integrity 
constraints. Column defaults) (#3919)
---
 .../java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java | 2 ++
 .../org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java     | 2 ++
 .../java/org/apache/ignite/internal/sql/engine/ItDmlTest.java           | 2 ++
 3 files changed, 6 insertions(+)

diff --git 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
index 903e135eb2..473f73b399 100644
--- 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
+++ 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItAlterTableDdlTest.java
@@ -197,6 +197,7 @@ public class ItAlterTableDdlTest extends 
BaseSqlIntegrationTest {
     // TODO https://issues.apache.org/jira/browse/IGNITE-19162 Fix test to 
ensure time/timestamp columns created with desired precision.
     @Test
     public void addColumnWithConstantDefault() {
+        // // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         sql("CREATE TABLE test(id BIGINT DEFAULT 1 PRIMARY KEY)");
 
         sql("ALTER TABLE test ADD COLUMN valint INTEGER DEFAULT 1");
@@ -223,6 +224,7 @@ public class ItAlterTableDdlTest extends 
BaseSqlIntegrationTest {
     @Test
     @SuppressWarnings("ThrowableNotThrown")
     public void doNotAllowFunctionsInNonPkColumns() {
+        // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         sql("CREATE TABLE t (id VARCHAR PRIMARY KEY, val VARCHAR)");
 
         assertThrowsSqlException(
diff --git 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java
 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java
index 4d3261235d..a6bc7cbacc 100644
--- 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java
+++ 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java
@@ -219,6 +219,7 @@ public class ItCreateTableDdlTest extends 
BaseSqlIntegrationTest {
 
     @Test
     public void literalAsColumDefault() {
+        // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         sql("CREATE TABLE T0("
                 + "id BIGINT DEFAULT 1 PRIMARY KEY, "
                 + "valdate DATE DEFAULT DATE '2001-12-21',"
@@ -236,6 +237,7 @@ public class ItCreateTableDdlTest extends 
BaseSqlIntegrationTest {
     @Test
     @SuppressWarnings("ThrowableNotThrown")
     public void doNotAllowFunctionsInNonPkColumns() {
+        // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         assertThrowsSqlException(
                 STMT_VALIDATION_ERR,
                 "Functional defaults are not supported for non-primary key 
columns",
diff --git 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
index d187b2df22..0f447f370f 100644
--- 
a/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
+++ 
b/modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java
@@ -194,6 +194,7 @@ public class ItDmlTest extends BaseSqlIntegrationTest {
 
     @Test
     public void testNullDefault() {
+        // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         sql("CREATE TABLE test_null_def (id INTEGER PRIMARY KEY, col INTEGER 
DEFAULT NULL)");
 
         sql("INSERT INTO test_null_def VALUES(1, DEFAULT)");
@@ -630,6 +631,7 @@ public class ItDmlTest extends BaseSqlIntegrationTest {
     @Test
     public void testDropDefault() {
         // SQL Standard 2016 feature F221 - Explicit defaults
+        // SQL Standard 2016 feature E141-07 - Basic integrity constraints. 
Column defaults
         for (DefaultValueArg arg : 
defaultValueArgs().collect(Collectors.toList())) {
             try {
                 sql(format("CREATE TABLE test (id INT PRIMARY KEY, val {} 
DEFAULT {})", arg.sqlType, arg.sqlVal));