This is an automated email from the ASF dual-hosted git repository.
mpochatkin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 435ffc218d IGNITE-23687 Add missing tests (#4729)
435ffc218d is described below
commit 435ffc218db7f2b900b6b0b0a8bc550f6c8c5f01
Author: Vadim Pakhnushev <[email protected]>
AuthorDate: Mon Nov 18 15:57:10 2024 +0300
IGNITE-23687 Add missing tests (#4729)
---
.../cli/commands/ItNotInitializedClusterTest.java | 18 +++++++++++-------
.../ItTopologyCommandInitializedClusterTest.java | 2 +-
.../ItTopologyCommandNotInitializedClusterTest.java | 15 ---------------
3 files changed, 12 insertions(+), 23 deletions(-)
diff --git
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/ItNotInitializedClusterTest.java
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/ItNotInitializedClusterTest.java
index a8bbd5b7bf..ad7eb3e094 100644
---
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/ItNotInitializedClusterTest.java
+++
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/ItNotInitializedClusterTest.java
@@ -47,18 +47,22 @@ public class ItNotInitializedClusterTest extends
CliCommandTestNotInitializedInt
private static Stream<Arguments> commands() {
return Stream.of(
arguments("node metric list", "Cannot list metrics"),
- arguments("node metric source list", "Cannot list metric
sources"),
arguments("node metric source enable metricName", "Cannot
enable metrics"),
arguments("node metric source disable metricName", "Cannot
disable metrics"),
- arguments("cluster metric source list", "Cannot list metric
sources"),
+ arguments("node metric source list", "Cannot list metric
sources"),
+ arguments("node unit list", "Cannot list units"),
+ arguments("cluster config show", "Cannot show cluster config"),
+ arguments("cluster config update test", "Cannot update cluster
config"),
+ arguments("cluster topology logical", "Cannot show logical
topology"),
+ arguments("cluster unit deploy test.unit.id.1 --version 1.0.0
--path " + testFile, "Cannot deploy unit"),
+ arguments("cluster unit undeploy test.unit.id.2 --version
1.0.0", "Cannot undeploy unit"),
+ arguments("cluster unit list", "Cannot list units"),
arguments("cluster metric source enable metricName", "Cannot
enable metrics"),
arguments("cluster metric source disable metricName", "Cannot
disable metrics"),
- arguments("recovery partitions reset --table tableName --zone
zoneName", "Cannot reset partitions"),
- arguments("recovery partitions states --global", "Cannot list
partition states"),
+ arguments("cluster metric source list", "Cannot list metric
sources"),
arguments("recovery partitions restart --table tableName
--zone zoneName", "Cannot restart partitions"),
- arguments("cluster unit deploy test.unit.id.1 --version 1.0.0
--path " + testFile, "Cannot deploy unit"),
- arguments("cluster unit undeploy test.unit.id.2 --version
1.0.0", "Cannot undeploy unit"),
- arguments("node unit list", "Cannot list units")
+ arguments("recovery partitions reset --table tableName --zone
zoneName", "Cannot reset partitions"),
+ arguments("recovery partitions states --global", "Cannot list
partition states")
);
}
diff --git
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandInitializedClusterTest.java
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandInitializedClusterTest.java
index 0e7b9b376d..1ac6ceeeea 100644
---
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandInitializedClusterTest.java
+++
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandInitializedClusterTest.java
@@ -43,7 +43,7 @@ class ItTopologyCommandInitializedClusterTest extends
CliIntegrationTest {
}
@Test
- @DisplayName("Should print logical topology when valid cluster url is
provided but cluster")
+ @DisplayName("Should print logical topology when valid cluster url is
provided")
void printLogicalTopology() {
// When
execute("cluster", "topology", "logical", "--url", NODE_URL);
diff --git
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandNotInitializedClusterTest.java
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandNotInitializedClusterTest.java
index 1ea37fe92f..1a28f9546b 100644
---
a/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandNotInitializedClusterTest.java
+++
b/modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/cluster/topology/ItTopologyCommandNotInitializedClusterTest.java
@@ -41,19 +41,4 @@ class ItTopologyCommandNotInitializedClusterTest extends
CliCommandTestNotInitia
this::assertOutputIsNotEmpty
);
}
-
- @Test
- @DisplayName("Should not print logical topology when valid cluster url is
provided but cluster is not initialized")
- void printLogicalTopology() {
- // When
- execute("cluster", "topology", "logical", "--url", NODE_URL);
-
- // Then prints nothing
- assertAll(
- this::assertOutputIsEmpty,
- () -> assertErrOutputContains("Cannot show logical topology" +
System.lineSeparator()
- + "Probably, you have not initialized the
cluster, try to run ignite cluster init command"
- )
- );
- }
}
