This is an automated email from the ASF dual-hosted git repository.
tkalkirill pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 6f489d5083a IGNITE-26997 Always use random access IO for checkpoint in
aipersist (#6951)
6f489d5083a is described below
commit 6f489d5083ae399d3d8b07a92e66ce74218d6069
Author: Ivan Zlenko <[email protected]>
AuthorDate: Thu Nov 13 13:43:12 2025 +0500
IGNITE-26997 Always use random access IO for checkpoint in aipersist (#6951)
---
.../throttling/PageMemoryThrottlingTest.java | 4 ++--
.../compatibility/configuration/ignite-snapshot.bin | Bin 5524 -> 5541 bytes
.../pagememory/PersistentPageMemoryStorageEngine.java | 5 +----
...geMemoryStorageEngineLocalConfigurationModule.java | 6 ++++++
.../PageMemoryCheckpointConfigurationSchema.java | 4 ----
5 files changed, 9 insertions(+), 10 deletions(-)
diff --git
a/modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/PageMemoryThrottlingTest.java
b/modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/PageMemoryThrottlingTest.java
index fe13e66e035..646f535fc05 100644
---
a/modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/PageMemoryThrottlingTest.java
+++
b/modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/PageMemoryThrottlingTest.java
@@ -46,8 +46,8 @@ import java.util.concurrent.atomic.AtomicLong;
import java.util.stream.IntStream;
import
org.apache.ignite.internal.configuration.testframework.ConfigurationExtension;
import org.apache.ignite.internal.failure.FailureManager;
-import org.apache.ignite.internal.fileio.AsyncFileIoFactory;
import org.apache.ignite.internal.fileio.FileIoFactory;
+import org.apache.ignite.internal.fileio.RandomAccessFileIoFactory;
import org.apache.ignite.internal.lang.IgniteInternalCheckedException;
import org.apache.ignite.internal.lang.RunnableX;
import org.apache.ignite.internal.pagememory.DataRegion;
@@ -136,7 +136,7 @@ public class PageMemoryThrottlingTest extends
IgniteAbstractTest {
FailureManager failureManager = mock(FailureManager.class);
when(failureManager.process(any())).thenThrow(new
AssertionError("Unexpected error"));
- fileIoFactory = spy(new AsyncFileIoFactory());
+ fileIoFactory = spy(new RandomAccessFileIoFactory());
pageStoreManager = new FilePageStoreManager("test", workDir,
fileIoFactory, PAGE_SIZE, failureManager);
List<DataRegion<PersistentPageMemory>> dataRegions = new
CopyOnWriteArrayList<>();
diff --git
a/modules/runner/src/test/resources/compatibility/configuration/ignite-snapshot.bin
b/modules/runner/src/test/resources/compatibility/configuration/ignite-snapshot.bin
index 9f26d4e8045..5e8f8a12f19 100644
Binary files
a/modules/runner/src/test/resources/compatibility/configuration/ignite-snapshot.bin
and
b/modules/runner/src/test/resources/compatibility/configuration/ignite-snapshot.bin
differ
diff --git
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java
index 767c153b92a..1bab2fcc070 100644
---
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java
+++
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java
@@ -35,7 +35,6 @@ import org.apache.ignite.internal.components.LogSyncer;
import org.apache.ignite.internal.components.LongJvmPauseDetector;
import org.apache.ignite.internal.configuration.SystemLocalConfiguration;
import org.apache.ignite.internal.failure.FailureManager;
-import org.apache.ignite.internal.fileio.AsyncFileIoFactory;
import org.apache.ignite.internal.fileio.FileIoFactory;
import org.apache.ignite.internal.fileio.RandomAccessFileIoFactory;
import org.apache.ignite.internal.hlc.HybridClock;
@@ -184,9 +183,7 @@ public class PersistentPageMemoryStorageEngine extends
AbstractPageMemoryStorage
int pageSize = engineConfig.pageSizeBytes().value();
try {
- FileIoFactory fileIoFactory =
engineConfig.checkpoint().useAsyncFileIoFactory().value()
- ? new AsyncFileIoFactory()
- : new RandomAccessFileIoFactory();
+ var fileIoFactory = new RandomAccessFileIoFactory();
filePageStoreManager =
createFilePageStoreManager(igniteInstanceName, storagePath, fileIoFactory,
pageSize, failureManager);
diff --git
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageEngineLocalConfigurationModule.java
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageEngineLocalConfigurationModule.java
index b283b8318d7..c9f52c92ebc 100644
---
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageEngineLocalConfigurationModule.java
+++
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageEngineLocalConfigurationModule.java
@@ -20,6 +20,7 @@ package
org.apache.ignite.internal.storage.pagememory.configuration;
import com.google.auto.service.AutoService;
import java.util.Collection;
import java.util.List;
+import java.util.Set;
import org.apache.ignite.configuration.ConfigurationModule;
import org.apache.ignite.configuration.NamedListChange;
import org.apache.ignite.configuration.SuperRootChange;
@@ -73,4 +74,9 @@ public class PageMemoryStorageEngineLocalConfigurationModule
implements Configur
});
}
}
+
+ @Override
+ public Collection<String> deletedPrefixes() {
+ return
Set.of("ignite.storage.engines.aipersist.checkpoint.useAsyncFileIoFactory");
+ }
}
diff --git
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/schema/PageMemoryCheckpointConfigurationSchema.java
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/schema/PageMemoryCheckpointConfigurationSchema.java
index 31b8c3f0ea1..b8bc6013c03 100644
---
a/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/schema/PageMemoryCheckpointConfigurationSchema.java
+++
b/modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/schema/PageMemoryCheckpointConfigurationSchema.java
@@ -69,8 +69,4 @@ public class PageMemoryCheckpointConfigurationSchema {
@Value(hasDefault = true)
@PublicName(legacyNames = "logReadLockThresholdTimeout")
public long logReadLockThresholdTimeoutMillis =
CheckpointConfiguration.DEFAULT_CHECKPOINT_LOG_READ_LOCK_THRESHOLD_TIMEOUT;
-
- /** Use an asynchronous file I/O operations provider. */
- @Value(hasDefault = true)
- public boolean useAsyncFileIoFactory = true;
}
