This is an automated email from the ASF dual-hosted git repository.

wernerdv pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git


The following commit(s) were added to refs/heads/master by this push:
     new c68c244b52e IGNITE-29239 Fix flaky 
TcpDiscoverySelfTest.testGetEffectiveNodeAddressesFiltersUnresolvedAddressWithoutNpe
 (#13776)
c68c244b52e is described below

commit c68c244b52e2cd744ed47010c4bc7d82fa3eb29f
Author: Dmitry Werner <[email protected]>
AuthorDate: Mon Nov 2 15:11:50 2026 +0800

    IGNITE-29239 Fix flaky 
TcpDiscoverySelfTest.testGetEffectiveNodeAddressesFiltersUnresolvedAddressWithoutNpe
 (#13776)
---
 .../spi/discovery/tcp/TcpDiscoverySelfTest.java    | 26 +++++-----------------
 1 file changed, 6 insertions(+), 20 deletions(-)

diff --git 
a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java
 
b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java
index ab1fc3a9e96..d358985fcb7 100644
--- 
a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java
+++ 
b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java
@@ -2383,32 +2383,18 @@ public class TcpDiscoverySelfTest extends 
GridCommonAbstractTest {
 
             assertNotNull(realNode);
 
-            // Wrap real node so that socketAddresses() returns an unresolved 
InetSocketAddress.
             TcpDiscoveryNode nodeWithUnresolvedAddr = new 
TestTcpDiscoveryNodeWithUnresolvedAddress(realNode);
 
-            // Ensure the wrapped node is considered different from the local 
node by UUID.
             assertNotEquals(ignite1.localNode().id(), 
nodeWithUnresolvedAddr.id());
 
-            // Verify test node has at least one unresolved address.
-            boolean hasUnresolved = false;
-
-            for (InetSocketAddress addr : 
nodeWithUnresolvedAddr.socketAddresses()) {
-                if (addr.getAddress() == null) {
-                    hasUnresolved = true;
-
-                    break;
-                }
-            }
-
-            assertTrue("Test node should have at least one unresolved 
address", hasUnresolved);
+            assertTrue("Test node should have at least one unresolved address",
+                
nodeWithUnresolvedAddr.socketAddresses().stream().anyMatch(addr -> 
addr.getAddress() == null));
 
             // Should not throw NPE; unresolved addresses must be filtered out.
             LinkedHashSet<InetSocketAddress> effAddrs = 
spi1.getEffectiveNodeAddresses(nodeWithUnresolvedAddr, false);
 
-            assertNotNull(effAddrs);
-
-            for (InetSocketAddress addr : effAddrs)
-                assertNotNull("Unresolved address (getAddress() == null) 
should have been filtered out", addr.getAddress());
+            assertTrue("Unresolved address (getAddress() == null) should have 
been filtered out",
+                effAddrs.stream().noneMatch(addr -> addr.getAddress() == 
null));
         }
         finally {
             stopAllGrids();
@@ -2984,8 +2970,8 @@ public class TcpDiscoverySelfTest extends 
GridCommonAbstractTest {
         @Override public Collection<InetSocketAddress> socketAddresses() {
             List<InetSocketAddress> addrs = new 
ArrayList<>(super.socketAddresses());
 
-            // Unresolved address: getAddress() returns null.
-            addrs.add(new 
InetSocketAddress("unresolved-host-name-that-does-not-resolve-xyz", 47500));
+            // Unlike new InetSocketAddress(host, port), does no DNS lookup, 
so getAddress() is always null.
+            addrs.add(InetSocketAddress.createUnresolved("unresolved", 47500));
 
             return addrs;
         }

Reply via email to