IMPALA-6516: Log catalog update only if the catalog version changes Impalad writes a line of log whenever a statestore catalog update comes in. This patch removes the logging when the catalog version doesn't change.
Change-Id: I04b8dd05c588d4cd91e9ca2251f8f66325bb45e2 Reviewed-on: http://gerrit.cloudera.org:8080/9311 Reviewed-by: Michael Ho <k...@cloudera.com> Reviewed-by: anujphadke <apha...@cloudera.com> Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/185c78fd Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/185c78fd Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/185c78fd Branch: refs/heads/2.x Commit: 185c78fd45fc643ccf1e6c989babda39dcaa40b9 Parents: 85c3c4d Author: Tianyi Wang <tw...@cloudera.com> Authored: Tue Feb 13 13:21:35 2018 -0800 Committer: Impala Public Jenkins <impala-public-jenk...@gerrit.cloudera.org> Committed: Wed Feb 14 08:09:59 2018 +0000 ---------------------------------------------------------------------- be/src/service/impala-server.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/185c78fd/be/src/service/impala-server.cc ---------------------------------------------------------------------- diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc index ee8405b..cff53e7 100644 --- a/be/src/service/impala-server.cc +++ b/be/src/service/impala-server.cc @@ -1352,13 +1352,15 @@ void ImpalaServer::CatalogUpdateCallback( } else { { unique_lock<mutex> unique_lock(catalog_version_lock_); + if (catalog_update_info_.catalog_version != resp.new_catalog_version) { + LOG(INFO) << "Catalog topic update applied with version: " << + resp.new_catalog_version << " new min catalog object version: " << + resp.min_catalog_object_version; + } catalog_update_info_.catalog_version = resp.new_catalog_version; catalog_update_info_.catalog_topic_version = delta.to_version; catalog_update_info_.catalog_service_id = resp.catalog_service_id; catalog_update_info_.min_catalog_object_version = resp.min_catalog_object_version; - LOG(INFO) << "Catalog topic update applied with version: " << - resp.new_catalog_version << " new min catalog object version: " << - resp.min_catalog_object_version; catalog_update_info_.UpdateCatalogVersionMetrics(); } ImpaladMetrics::CATALOG_READY->SetValue(resp.new_catalog_version > 0);
