Repository: impala Updated Branches: refs/heads/2.x a73b8f833 -> ff38d6299
IMPALA-6599: fixes return for NativeLibCacheSetNeedsRefresh Current fe_support.cc:[..]_FeSupport_NativeLibCacheSetNeedsRefresh always returns false. In the frontend, this is logged, which causes unneeded, incorrect, and confusing spam. This method returns false if unable to manage the string input argument (path). It then invokes the lib_cache's SetNeedsRefresh which always succeeds (either the path does not exist or, if it exists, needs refresh is set). This change modifies the return value after this call to be true instead of false. Testing: - verified the spam without the change by looking at the logs from query_test/test_udfs.py (~4000 log messages) - verified that none of these log messages show up with the change applied. Change-Id: I11f34a63a25f5ab6acabcc2f52b7e8f22d8a4da3 Reviewed-on: http://gerrit.cloudera.org:8080/9497 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/ff38d629 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/ff38d629 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/ff38d629 Branch: refs/heads/2.x Commit: ff38d6299e36a3ed6b7ab2aee130f7b7e5e2e09c Parents: fc1578e Author: Vuk Ercegovac <vercego...@cloudera.com> Authored: Mon Mar 5 11:16:37 2018 -0800 Committer: Impala Public Jenkins <impala-public-jenk...@gerrit.cloudera.org> Committed: Tue Mar 6 01:10:15 2018 +0000 ---------------------------------------------------------------------- be/src/service/fe-support.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/ff38d629/be/src/service/fe-support.cc ---------------------------------------------------------------------- diff --git a/be/src/service/fe-support.cc b/be/src/service/fe-support.cc index 2b6e2fd..2d48d73 100644 --- a/be/src/service/fe-support.cc +++ b/be/src/service/fe-support.cc @@ -469,7 +469,7 @@ Java_org_apache_impala_service_FeSupport_NativeLibCacheSetNeedsRefresh(JNIEnv* e str.assign(hdfs_location_data.get()); } LibCache::instance()->SetNeedsRefresh(str); - return static_cast<jboolean>(false); + return static_cast<jboolean>(true); } extern "C"
