Fix test dimensions in test_errorlog.py Bug: The test dimensions were set up such that the test ran for all text-format variants (including compressed text)
The test is file-format independent and slow (>40s), so we should only run it once. Change-Id: Icac90d308337f2cfb51e7de5bd23d410da073a73 Reviewed-on: http://gerrit.cloudera.org:8080/9546 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/d3c115ae Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/d3c115ae Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/d3c115ae Branch: refs/heads/master Commit: d3c115ae9aefac6317a2b9b96745702c43bce804 Parents: 6c264d8 Author: Alex Behm <alex.b...@cloudera.com> Authored: Wed Mar 7 16:27:32 2018 -0800 Committer: Impala Public Jenkins <impala-public-jenk...@gerrit.cloudera.org> Committed: Sat Mar 10 01:33:03 2018 +0000 ---------------------------------------------------------------------- tests/query_test/test_errorlog.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/d3c115ae/tests/query_test/test_errorlog.py ---------------------------------------------------------------------- diff --git a/tests/query_test/test_errorlog.py b/tests/query_test/test_errorlog.py index 0580764..258dba0 100644 --- a/tests/query_test/test_errorlog.py +++ b/tests/query_test/test_errorlog.py @@ -20,7 +20,9 @@ # from tests.beeswax.impala_beeswax import ImpalaBeeswaxException from tests.common.impala_test_suite import ImpalaTestSuite -from tests.common.test_dimensions import create_exec_option_dimension +from tests.common.test_dimensions import ( + create_single_exec_option_dimension, + create_uncompressed_text_dimension) from time import sleep # Test injecting error logs in prepare phase and status::OK(). This tests one of race @@ -33,10 +35,9 @@ class TestErrorLogs(ImpalaTestSuite): @classmethod def add_test_dimensions(cls): super(TestErrorLogs, cls).add_test_dimensions() - cls.ImpalaTestMatrix.add_constraint(lambda v:\ - v.get_value('table_format').file_format == 'text') - cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension( - cluster_sizes=[0], disable_codegen_options=[False], batch_sizes=[0])) + cls.ImpalaTestMatrix.add_dimension(create_single_exec_option_dimension()) + cls.ImpalaTestMatrix.add_dimension( + create_uncompressed_text_dimension(cls.get_workload())) def test_errorlog(self, vector): query = 'select count(*) from tpch.lineitem;'
