KUDU-2385: Fix typo in KinitContext::DoRenewal() On platforms without krb5_get_init_creds_opt_set_out_ccache(), krb5_cc_store_cred() is called to insert the newly acquired credential into the ccache. However, there was a typo in the code which resulted in inserting the old credential into ccache. This change fixes the typo to make sure the new credential is inserted into ccache.
Testing done: confirmed on SLES11 that the new credential is being inserted by checking the 'auth time' of the ticket in ccache. Impala uses a slightly different #ifdef which explicitly checks if krb5_get_init_creds_opt_set_out_ccache() is defined on the platform so this code path is actually used when running Impala on SLES11. Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c Reviewed-on: http://gerrit.cloudera.org:8080/9840 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Todd Lipcon <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/9842 Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/77efb282 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/77efb282 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/77efb282 Branch: refs/heads/master Commit: 77efb2820e62f8066c2ee00593bd5deeb9f7d9a6 Parents: 2883c99 Author: Michael Ho <[email protected]> Authored: Wed Mar 28 10:53:24 2018 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Thu Mar 29 01:40:06 2018 +0000 ---------------------------------------------------------------------- be/src/kudu/security/init.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/77efb282/be/src/kudu/security/init.cc ---------------------------------------------------------------------- diff --git a/be/src/kudu/security/init.cc b/be/src/kudu/security/init.cc index 7674c7e..340ba75 100644 --- a/be/src/kudu/security/init.cc +++ b/be/src/kudu/security/init.cc @@ -299,7 +299,7 @@ Status KinitContext::DoRenewal() { KRB5_RETURN_NOT_OK_PREPEND(krb5_cc_initialize(g_krb5_ctx, ccache_, principal_), "Reacquire error: could not init ccache"); - KRB5_RETURN_NOT_OK_PREPEND(krb5_cc_store_cred(g_krb5_ctx, ccache_, &creds), + KRB5_RETURN_NOT_OK_PREPEND(krb5_cc_store_cred(g_krb5_ctx, ccache_, &new_creds), "Reacquire error: could not store creds in cache"); #endif }
