Repository: impala Updated Branches: refs/heads/master 0833408fd -> d8ab804e3
Fix minor perf bug in BufferedTupleStream The code referenced a member variable when the intent was clearly to use the template argument. Change-Id: I05bae0018f79aec9c6014ae228ff28621b548860 Reviewed-on: http://gerrit.cloudera.org:8080/10239 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/d8ab804e Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/d8ab804e Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/d8ab804e Branch: refs/heads/master Commit: d8ab804e3e04a778fa10bd43efa4654ca96f7fe9 Parents: 0833408 Author: Tim Armstrong <[email protected]> Authored: Mon Apr 30 09:08:11 2018 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Mon Apr 30 20:37:42 2018 +0000 ---------------------------------------------------------------------- be/src/runtime/buffered-tuple-stream.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/d8ab804e/be/src/runtime/buffered-tuple-stream.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/buffered-tuple-stream.cc b/be/src/runtime/buffered-tuple-stream.cc index f5668c7..9326507 100644 --- a/be/src/runtime/buffered-tuple-stream.cc +++ b/be/src/runtime/buffered-tuple-stream.cc @@ -1038,7 +1038,7 @@ template <bool HAS_NULLABLE_TUPLE> void BufferedTupleStream::UnflattenTupleRow(uint8_t** data, TupleRow* row) const { const int tuples_per_row = desc_->tuple_descriptors().size(); uint8_t* ptr = *data; - if (has_nullable_tuple_) { + if (HAS_NULLABLE_TUPLE) { // Stitch together the tuples from the page and the NULL ones. const uint8_t* null_indicators = ptr; ptr += NullIndicatorBytesPerRow();
