IMPALA-7043: HBase split failure should not fail dataload HBase splitting can fail due to changes in HBase code. It is useful to still do tests even if HBase splitting failed. As it is today, buildall.sh will abort if create-load-data.sh's invocation of split-hbase.sh fails. No tests run, even though the HBase splitting affects only a small portion of our tests.
This changes create-load-data.sh to keep going with dataload if HBase splitting fails. It outputs the same errors to the log as it would before this change. It adds a message to explain that it is ignoring the failure and there may be related test failures. Change-Id: I7497fe8c9f1655a34b2743462d8b7248eb94554e Reviewed-on: http://gerrit.cloudera.org:8080/10437 Reviewed-by: Philip Zeyliger <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/2e9f5c90 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/2e9f5c90 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/2e9f5c90 Branch: refs/heads/master Commit: 2e9f5c90ebbe0a9b63db92238787071b027b2c66 Parents: 6af6569 Author: Joe McDonnell <[email protected]> Authored: Wed May 16 14:41:37 2018 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Thu May 17 09:13:01 2018 +0000 ---------------------------------------------------------------------- testdata/bin/create-load-data.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/2e9f5c90/testdata/bin/create-load-data.sh ---------------------------------------------------------------------- diff --git a/testdata/bin/create-load-data.sh b/testdata/bin/create-load-data.sh index e5b0f87..88b3cb5 100755 --- a/testdata/bin/create-load-data.sh +++ b/testdata/bin/create-load-data.sh @@ -591,7 +591,11 @@ if [ "${TARGET_FILESYSTEM}" = "hdfs" ]; then # HBase splitting is only relevant for FE tests if [[ -z "$REMOTE_LOAD" ]]; then - run-step "Splitting HBase" create-hbase.log ${IMPALA_HOME}/testdata/bin/split-hbase.sh + IGNORE_MSG="Ignoring this HBase splitting failure to allow dataload to complete and + tests to run. This failure will cause some frontend tests to fail, and it may + impact some HBase tests. Other tests are unaffected." + run-step "Splitting HBase" create-hbase.log ${IMPALA_HOME}/testdata/bin/split-hbase.sh \ + || echo ${IGNORE_MSG} fi run-step "Creating internal HBase table" create-internal-hbase-table.log \
