Repository: impala Updated Branches: refs/heads/2.x 564687265 -> b1ac8b95a
IMPALA-6953: part 1: clean up DiskIoMgr There should be no behavioural changes as a result of this refactoring. Make DiskQueue an encapsulated class. Remove friend classes where possible, either by using public methods or moving code between classes. Move method into protected in some cases. Split GetNextRequestRange() into two methods that operate on DiskQueue and RequestContext state. The methods belong to the respective classes. Reduce transitive #include dependencies to hopefully help with build time. Testing: Ran core tests. Change-Id: I5a6e393f8c01d10143cbac91108af37f6498c1b1 Reviewed-on: http://gerrit.cloudera.org:8080/10245 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/10532 Reviewed-by: Thomas Marshall <[email protected]> Tested-by: Thomas Marshall <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/f76cf257 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/f76cf257 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/f76cf257 Branch: refs/heads/2.x Commit: f76cf25725238f601544b8d660a5aa32a8e5f7cf Parents: 5646872 Author: Tim Armstrong <[email protected]> Authored: Sat Apr 28 11:27:53 2018 -0700 Committer: Tim Armstrong <[email protected]> Committed: Wed May 30 01:11:09 2018 +0000 ---------------------------------------------------------------------- ----------------------------------------------------------------------
