Repository: impala Updated Branches: refs/heads/master effe4e666 -> add651c11
IMPALA-7014: Disable stacktrace symbolisation by default Stacktrace symbolization has been shown to be 2500x slower compared to just printing the un-symbolized one. This has burned us a few times now, so let's disable it by default. Change-Id: If3af209890ccc242beb742145c63eb6836d4bfbb Reviewed-on: http://gerrit.cloudera.org:8080/10964 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/98007611 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/98007611 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/98007611 Branch: refs/heads/master Commit: 980076117f43d2189b5fc9484ef0c1c54c2c18c1 Parents: effe4e6 Author: Zoram Thanga <[email protected]> Authored: Tue Jul 17 15:01:39 2018 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Wed Jul 18 02:43:30 2018 +0000 ---------------------------------------------------------------------- be/src/common/init.cc | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/98007611/be/src/common/init.cc ---------------------------------------------------------------------- diff --git a/be/src/common/init.cc b/be/src/common/init.cc index ffbb165..2842c39 100644 --- a/be/src/common/init.cc +++ b/be/src/common/init.cc @@ -69,6 +69,7 @@ DECLARE_int32(max_log_files); DECLARE_int32(max_minidumps); DECLARE_string(redaction_rules_file); DECLARE_string(reserved_words_version); +DECLARE_bool(symbolize_stacktrace); DEFINE_int32(max_audit_event_log_files, 0, "Maximum number of audit event log files " "to retain. The most recent audit event log files are retained. If set to 0, " @@ -189,6 +190,7 @@ void impala::InitCommonRuntime(int argc, char** argv, bool init_jvm, // Set the default hostname. The user can override this with the hostname flag. ABORT_IF_ERROR(GetHostname(&FLAGS_hostname)); + FLAGS_symbolize_stacktrace = false; google::SetVersionString(impala::GetBuildVersion()); google::ParseCommandLineFlags(&argc, &argv, true); if (!FLAGS_redaction_rules_file.empty()) {
