test_recover_partitions.py had asserts that were always true. Running "python -m compileall" discovered some assertions that were always true. I've re-instated them to their true spirit.
Change-Id: Id49171304b853f15c43c8cfca066b6694c4a669f Reviewed-on: http://gerrit.cloudera.org:8080/10993 Reviewed-by: Vuk Ercegovac <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/2a40e8f2 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/2a40e8f2 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/2a40e8f2 Branch: refs/heads/master Commit: 2a40e8f2a973391b61165ebd95cb30b9b67d93ba Parents: 1d491d6 Author: Philip Zeyliger <[email protected]> Authored: Thu Jul 19 10:09:11 2018 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Thu Jul 19 20:35:31 2018 +0000 ---------------------------------------------------------------------- tests/metadata/test_recover_partitions.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/2a40e8f2/tests/metadata/test_recover_partitions.py ---------------------------------------------------------------------- diff --git a/tests/metadata/test_recover_partitions.py b/tests/metadata/test_recover_partitions.py index 1894676..9ba4164 100644 --- a/tests/metadata/test_recover_partitions.py +++ b/tests/metadata/test_recover_partitions.py @@ -346,12 +346,11 @@ class TestRecoverPartitions(ImpalaTestSuite): self.client, "ALTER TABLE %s RECOVER PARTITIONS" % FQ_TBL_NAME) result = self.execute_query_expect_success( self.client, "SHOW PARTITIONS %s" % FQ_TBL_NAME) - assert (self.count_partition(result.data) == 1, - "ALTER TABLE %s RECOVER PARTITIONS produced more than 1 partitions" % - FQ_TBL_NAME) - assert (self.count_value('p=100%25', result.data) == 1, - "ALTER TABLE %s RECOVER PARTITIONS failed to handle encoded partitioned value" % - FQ_TBL_NAME) + assert self.count_partition(result.data) == 1, \ + "ALTER TABLE %s RECOVER PARTITIONS produced more than 1 partitions" % FQ_TBL_NAME + assert self.count_value('p=100%25', result.data) == 1, \ + "ALTER TABLE %s RECOVER PARTITIONS failed to handle encoded partitioned value" % \ + FQ_TBL_NAME @SkipIfLocal.hdfs_client @SkipIfS3.empty_directory
