Repository: impala
Updated Branches:
  refs/heads/master ce145ffee -> 09150f04c


IMPALA-7628: skip test_tls_ecdh on Python 2.6

This is a temporary workaround. On the CentOS 6 build that failed
test_tls_v12, test_wildcard_san_ssl and test_wildcard_ssl were
all skipped so I figured this will unblock the tests without
losing coverage on most platforms that have recent Python.

Change-Id: I94ae9d254d5fd337774a24106eb9b08585ac0b01
Reviewed-on: http://gerrit.cloudera.org:8080/11519
Reviewed-by: Thomas Marshall <thomasmarsh...@cmu.edu>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/09150f04
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/09150f04
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/09150f04

Branch: refs/heads/master
Commit: 09150f04cac84965e3b390404c57a51261aecf56
Parents: ce145ff
Author: Tim Armstrong <tarmstr...@cloudera.com>
Authored: Wed Sep 26 08:46:52 2018 -0700
Committer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Committed: Wed Sep 26 19:56:11 2018 +0000

----------------------------------------------------------------------
 tests/custom_cluster/test_client_ssl.py | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/09150f04/tests/custom_cluster/test_client_ssl.py
----------------------------------------------------------------------
diff --git a/tests/custom_cluster/test_client_ssl.py 
b/tests/custom_cluster/test_client_ssl.py
index cbc2f74..81afd52 100644
--- a/tests/custom_cluster/test_client_ssl.py
+++ b/tests/custom_cluster/test_client_ssl.py
@@ -120,6 +120,8 @@ class TestClientSsl(CustomClusterTestSuite):
                                     statestored_args=TLS_ECDH_ARGS,
                                     catalogd_args=TLS_ECDH_ARGS)
   @pytest.mark.skipif(HAS_LEGACY_OPENSSL, reason=SKIP_SSL_MSG)
+  @pytest.mark.skipif(sys.version_info < 
REQUIRED_MIN_PYTHON_VERSION_FOR_TLSV12,
+      reason="Working around IMPALA-7628. TODO: is the right workaround?")
   def test_tls_ecdh(self, vector):
     self._verify_negative_cases()
     self._validate_positive_cases("%s/server-cert.pem" % self.CERT_DIR)

Reply via email to