Repository: impala Updated Branches: refs/heads/master 07fd33208 -> af7476d55
IMPALA-7882: Remove StringValue padding validation Previously, the StringValue test in the llvm-codegen-test validated the padding bytes. The validation check was invalidated by IMPALA-7367. This change removes that check. Testing: Ran core tests with ASAN enabled. Change-Id: I3e7247b416ae9e1bc6da299572f2b6f326ad1c71 Reviewed-on: http://gerrit.cloudera.org:8080/11989 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/impala/repo Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/af7476d5 Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/af7476d5 Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/af7476d5 Branch: refs/heads/master Commit: af7476d550bcf8b3819bd4816bfe0c16ea78758a Parents: 07fd332 Author: poojanilangekar <[email protected]> Authored: Mon Nov 26 13:25:05 2018 -0800 Committer: Impala Public Jenkins <[email protected]> Committed: Tue Nov 27 05:01:40 2018 +0000 ---------------------------------------------------------------------- be/src/codegen/llvm-codegen-test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/impala/blob/af7476d5/be/src/codegen/llvm-codegen-test.cc ---------------------------------------------------------------------- diff --git a/be/src/codegen/llvm-codegen-test.cc b/be/src/codegen/llvm-codegen-test.cc index 3748ced..f77d8df 100644 --- a/be/src/codegen/llvm-codegen-test.cc +++ b/be/src/codegen/llvm-codegen-test.cc @@ -373,10 +373,10 @@ TEST_F(LlvmCodeGenTest, StringValue) { EXPECT_EQ(1, str_val.len); EXPECT_EQ(static_cast<void*>(str_val.ptr), static_cast<const void*>(str.c_str())); - // Validate padding bytes are unchanged + // After IMPALA-7367 removed the padding from the StringValue struct, validate the + // length byte alone. int32_t* bytes = reinterpret_cast<int32_t*>(&str_val); EXPECT_EQ(1, bytes[2]); // str_val.len - EXPECT_EQ(0, bytes[3]); // padding codegen->Close(); }
