This is an automated email from the ASF dual-hosted git repository. stakiar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit c67e0868e032d0aec95018612b121c18aed3b914 Author: Sahil Takiar <[email protected]> AuthorDate: Tue Oct 1 14:39:40 2019 -0700 IMPALA-8926, IMPALA-8989: Fix flaky result spooling tests Disable the tests TestResultSpooling::test_full_queue(_large_fetch) until we figure out why they are flaky. Replace the sleep in TestAdmissionController::test_release_backend with assert_eventually to reduce flakiness. Change-Id: I7ea6bf3d84f174745c8a0b1e0f2b55ce05ee618b Reviewed-on: http://gerrit.cloudera.org:8080/14337 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/custom_cluster/test_admission_controller.py | 5 +++-- tests/query_test/test_result_spooling.py | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/custom_cluster/test_admission_controller.py b/tests/custom_cluster/test_admission_controller.py index 27c3182..1887a83 100644 --- a/tests/custom_cluster/test_admission_controller.py +++ b/tests/custom_cluster/test_admission_controller.py @@ -1334,8 +1334,9 @@ class TestAdmissionController(TestAdmissionControllerBase, HS2TestSuite): # complete, and then validate that one of the executor backends shutdowns and # releases its admitted memory. self.wait_for_state(handle, self.client.QUERY_STATES['RUNNING'], timeout) - sleep(10) # Wait for the 'lineitem' scan to complete - assert "NumCompletedBackends: 1 (1)" in self.client.get_runtime_profile(handle) + # Once the 'lineitem' scan completes, NumCompletedBackends should be 1. + self.assert_eventually(60, 1, lambda: "NumCompletedBackends: 1 (1)" + in self.client.get_runtime_profile(handle)) get_num_completed_backends(self.cluster.impalads[0].service, handle.get_handle().id) == 1 mem_admitted = get_mem_admitted_backends_debug_page(self.cluster) diff --git a/tests/query_test/test_result_spooling.py b/tests/query_test/test_result_spooling.py index 6f3d732..6f54bed 100644 --- a/tests/query_test/test_result_spooling.py +++ b/tests/query_test/test_result_spooling.py @@ -15,6 +15,7 @@ # specific language governing permissions and limitations # under the License. +import pytest import re import time import threading @@ -103,11 +104,13 @@ class TestResultSpooling(ImpalaTestSuite): finally: self.client.close_query(handle) + @pytest.mark.xfail(run=False, reason="IMPALA-8926") def test_full_queue(self, vector): """Delegates to _test_full_queue.""" query = "select * from functional.alltypes order by id limit 1500" self._test_full_queue(vector, query) + @pytest.mark.xfail(run=False, reason="IMPALA-8926") def test_full_queue_large_fetch(self, vector): """Delegates to _test_full_queue, but specifies a fetch size equal to the number of rows returned by the query. This tests that clients can fetch all rows from a full
