This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 1e63722f8da7cd94a6937891832e51eae834c956
Author: Qifan Chen <qc...@cloudera.com>
AuthorDate: Wed Sep 2 15:06:14 2020 -0400
IMPALA-10124 admission-controller-test fails with no such file or
directory error
This work addresses a failure by disabling undefined behavior sanitizer
testing for AdmissionControllerTest.TopNQueryCheck test. In the test,
std::regex_match() is used to verify the appearance of certain strings
and can produce a core with very long stack trace failling in
std::vector::operator[]().
Testing:
1. Ran the test in both regular and disabling undefined behavior
sanitizer check modes. No core was seen.
Change-Id: I16d6cff8fad8d0e93a24ec3fefa9cc1f8c471aad
Reviewed-on: http://gerrit.cloudera.org:8080/16404
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
be/src/scheduling/admission-controller-test.cc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/be/src/scheduling/admission-controller-test.cc
b/be/src/scheduling/admission-controller-test.cc
index 16a22c3..3c05fed 100644
--- a/be/src/scheduling/admission-controller-test.cc
+++ b/be/src/scheduling/admission-controller-test.cc
@@ -956,7 +956,10 @@ TEST_F(AdmissionControllerTest,
DedicatedCoordAdmissionChecks) {
/// Test that AdmissionController can identify 5 queries with top memory
consumption
/// from 4 pools. Each pool holds a number of queries with different memory
consumptions.
+/// Run the test only when undefined behavior sanitizer check is off to avoid
core
+/// generated from std::regex_match().
TEST_F(AdmissionControllerTest, TopNQueryCheck) {
+#ifndef UNDEFINED_SANITIZER
// Pass the paths of the configuration files as command line flags
FLAGS_fair_scheduler_allocation_path =
GetResourceFile("fair-scheduler-test2.xml");
FLAGS_llama_site_path = GetResourceFile("llama-site-test2.xml");
@@ -1109,6 +1112,7 @@ TEST_F(AdmissionControllerTest, TopNQueryCheck) {
// Reset the consumption_ counter for all trackers so that TearDown() call
// can run cleanly.
ResetMemConsumed(pool_mem_tracker->GetRootMemTracker());
+#endif
}
} // end namespace impala
