This is an automated email from the ASF dual-hosted git repository.
boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 5e38f32 IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe
from latest Iceberg
5e38f32 is described below
commit 5e38f32f290e3ac139363ef0f1d94279f0360122
Author: skyyws <[email protected]>
AuthorDate: Tue Nov 10 20:11:50 2020 +0800
IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest
Iceberg
Iceberg already implements InputFormat/OutputFormat/SerDe in latest
version, so we need to update these classes in HdfsFileFormat.java
and HdfsStorageDescriptor.java, more details can be found in:
https://github.com/apache/iceberg/blob/0.10.x/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Reviewed-on: http://gerrit.cloudera.org:8080/16707
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java | 6 +++---
.../main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java | 2 +-
fe/src/main/java/org/apache/impala/catalog/IcebergTable.java | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
b/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
index 346c09f..db6c635 100644
--- a/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
+++ b/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
@@ -77,9 +77,9 @@ public enum HdfsFileFormat {
HUDI_PARQUET("org.apache.hudi.hadoop.HoodieParquetInputFormat",
"org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat",
"org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe", true,
true, true),
- ICEBERG("com.expediagroup.hiveberg.IcebergInputFormat",
- "org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat",
- "com.expediagroup.hiveberg.IcebergSerDe", false, false, false);
+ ICEBERG("org.apache.iceberg.mr.hive.HiveIcebergInputFormat",
+ "org.apache.iceberg.mr.hive.HiveIcebergOutputFormat",
+ "org.apache.iceberg.mr.hive.HiveIcebergSerDe", false, false, false);
private final String inputFormat_;
private final String outputFormat_;
diff --git
a/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
b/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
index f6ca7b0..fd993fe 100644
--- a/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
+++ b/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
@@ -72,7 +72,7 @@ public class HdfsStorageDescriptor {
// TODO: Verify the following Parquet SerDe works with Impala and add
// support for the new input/output format classes. See IMPALA-4214.
"org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe", //
(parquet)
- "com.expediagroup.hiveberg.IcebergSerDe"); // (iceberg)
+ "org.apache.iceberg.mr.hive.HiveIcebergSerDe"); // (iceberg)
private final static Logger LOG =
LoggerFactory.getLogger(HdfsStorageDescriptor.class);
diff --git a/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
b/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
index 3cc60ee..9c2742a 100644
--- a/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
+++ b/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
@@ -64,7 +64,7 @@ public class IcebergTable extends Table implements
FeIcebergTable {
// Iceberg specific value for the storage handler table property keyed by
// KEY_STORAGE_HANDLER.
public static final String ICEBERG_STORAGE_HANDLER =
- "com.expediagroup.hiveberg.IcebergStorageHandler";
+ "org.apache.iceberg.mr.hive.HiveIcebergStorageHandler";
// Iceberg file format key in tblproperties
public static final String ICEBERG_FILE_FORMAT = "iceberg.file_format";
