This is an automated email from the ASF dual-hosted git repository. tarmstrong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 3f2eab8764cb19d75de64a6bdc4c4cf982b201a0 Author: Tim Armstrong <[email protected]> AuthorDate: Mon Dec 21 12:34:52 2020 -0800 IMPALA-9966: Add missing breaks in SetQueryOption Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d Reviewed-on: http://gerrit.cloudera.org:8080/16892 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- be/src/service/query-options.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/be/src/service/query-options.cc b/be/src/service/query-options.cc index cc65f08..c986292 100644 --- a/be/src/service/query-options.cc +++ b/be/src/service/query-options.cc @@ -685,6 +685,7 @@ Status impala::SetQueryOption(const string& key, const string& value, value)); } query_options->__set_resource_trace_ratio(val); + break; } case TImpalaQueryOptions::PLANNER_TESTCASE_MODE: { query_options->__set_planner_testcase_mode(IsTrue(value)); @@ -865,6 +866,7 @@ Status impala::SetQueryOption(const string& key, const string& value, ParseMemValue(value, "broadcast bytes limit for join operations", &broadcast_bytes_limit)); query_options->__set_broadcast_bytes_limit(broadcast_bytes_limit); + break; } case TImpalaQueryOptions::RETRY_FAILED_QUERIES: { query_options->__set_retry_failed_queries(IsTrue(value)); @@ -969,11 +971,11 @@ Status impala::SetQueryOption(const string& key, const string& value, break; } case TImpalaQueryOptions::TARGETED_KUDU_SCAN_RANGE_LENGTH: { - int64_t scan_length = 0; - RETURN_IF_ERROR( - ParseMemValue(value, "targeted kudu scan range length", &scan_length)); - query_options->__set_targeted_kudu_scan_range_length(scan_length); - break; + int64_t scan_length = 0; + RETURN_IF_ERROR( + ParseMemValue(value, "targeted kudu scan range length", &scan_length)); + query_options->__set_targeted_kudu_scan_range_length(scan_length); + break; } case TImpalaQueryOptions::REPORT_SKEW_LIMIT: { StringParser::ParseResult result;
