This is an automated email from the ASF dual-hosted git repository.
wzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 62683e0eb IMPALA-11324: Fix broken test_reportexecstatus_retries
62683e0eb is described below
commit 62683e0ebb78902e142975971c93b8fa011fb632
Author: Riza Suminto <[email protected]>
AuthorDate: Fri May 27 11:01:07 2022 -0700
IMPALA-11324: Fix broken test_reportexecstatus_retries
TestRPCTimeout::test_reportexecstatus_retries is broken in exhaustive
exploration after IMPALA-10465. This patch fix the issue by changing the
test query to raise column constraint violation rather than primary key
conflict.
Testing:
- Pass custom_cluster/test_rpc_timeout.py::TestRPCTimeout in exhaustive
exploration.
Change-Id: I67b9555d823f5cf5be59900d89e305ef92e5e89f
Reviewed-on: http://gerrit.cloudera.org:8080/18573
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
tests/custom_cluster/test_rpc_timeout.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/custom_cluster/test_rpc_timeout.py
b/tests/custom_cluster/test_rpc_timeout.py
index 3023de2f7..5a93dbb0c 100644
--- a/tests/custom_cluster/test_rpc_timeout.py
+++ b/tests/custom_cluster/test_rpc_timeout.py
@@ -181,15 +181,18 @@ class TestRPCTimeout(CustomClusterTestSuite):
" --debug_actions=REPORT_EXEC_STATUS_DELAY:SLEEP@1000")
def test_reportexecstatus_retries(self, unique_database):
tbl = "%s.kudu_test" % unique_database
- self.execute_query("create table %s (a int primary key) stored as kudu" %
tbl)
+ self.execute_query("create table %s ("
+ "a bigint primary key, b bigint not null) stored as kudu" % tbl)
# Since the sleep time (1000ms) is much longer than the rpc timeout
(100ms), all
# reports will appear to fail. The query is designed to result in many
intermediate
# status reports but fewer than the max allowed failures, so the query
should succeed.
- result = self.execute_query(
- "insert into %s select 0 from tpch.lineitem limit 100000" % tbl)
+ result = self.execute_query("insert into %s select c_custkey, "
+ "case when c_custkey > 1 then null else c_custkey end "
+ "from tpch.customer order by c_custkey limit 100000" % tbl)
assert result.success, str(result)
# Ensure that the error log was tracked correctly - all but the first row
inserted
- # should result in a 'key already present' insert error.
+ # should result in a 'Row with null value violates nullability constraint
on table'
+ # insert error.
assert "(1 of 99999 similar)" in result.log, str(result)
@pytest.mark.execute_serially
