This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch branch-4.1.1 in repository https://gitbox.apache.org/repos/asf/impala.git
commit 15fd47ed1a5151bd620e404612c82cf7fe94e9b0 Author: Michael Smith <[email protected]> AuthorDate: Tue Jul 26 10:32:11 2022 -0700 IMPALA-11457 Fix regression with unknown disk id Fixes an issue where disk ID is set to 65536 incorrectly when storage ID is unknown due to mixed usage of short and ushort (introduced by d6b5f82e31732c355af3f3d1a8e5da94ba9c1349). The incorrect unknown disk ID would result in all local reads going to a single disk queue and reducing parallelism, which specifically happens with co-located Ozone endpoints. This issue caused the test_admission_control_with_multiple_coords to fail with Ozone. Change-Id: I571ac0669ceb6a42561594c3f96723d5ed293902 Reviewed-on: http://gerrit.cloudera.org:8080/18792 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/18914 Tested-by: Quanlong Huang <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- common/fbs/CatalogObjects.fbs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/fbs/CatalogObjects.fbs b/common/fbs/CatalogObjects.fbs index 629938c6c..ce0f1a693 100644 --- a/common/fbs/CatalogObjects.fbs +++ b/common/fbs/CatalogObjects.fbs @@ -52,8 +52,8 @@ table FbFileBlock { replica_host_idxs: [ushort] (id: 2); // The list of disk ids for the file block. May not be set if disk ids are not - // supported. - disk_ids: [ushort] (id: 3); + // supported. Set to -1 for unknown disk id. + disk_ids: [short] (id: 3); } table FbFileDesc {
