This is an automated email from the ASF dual-hosted git repository. boroknagyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 9b3385cee2b8e2c37a091dde45df360463386d8b Author: Daniel Becker <[email protected]> AuthorDate: Wed Dec 14 14:22:44 2022 +0100 IMPALA-11799: Fix example of the hs2_fp_format shell option IMPALA-10660 introduced the "hs2_fp_format" shell option. In the help section describing the query option it states: Use '%16G' to match Beeswax protocol's floating-point output format However, '%16G' is not accepted by the shell: bin/impala-shell.sh --hs2_fp_format='%16G' Invalid floating point format specification: %16G This commit changes the example to '16G'. Also corrected the name of the option in shell/impala_shell_config_defaults.py from 'fp_format_specification' to 'hs2_fp_format'. Change-Id: If53e69b495dfeb8d6d65878eff9580c5e12f793d Reviewed-on: http://gerrit.cloudera.org:8080/19359 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- shell/impala_shell_config_defaults.py | 2 +- shell/option_parser.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/shell/impala_shell_config_defaults.py b/shell/impala_shell_config_defaults.py index 2786fa8c3..c4caed252 100644 --- a/shell/impala_shell_config_defaults.py +++ b/shell/impala_shell_config_defaults.py @@ -58,5 +58,5 @@ impala_shell_defaults = { 'http_socket_timeout_s': None, 'global_config_default_path': '/etc/impalarc', 'strict_hs2_protocol': False, - 'fp_format_specification': None + 'hs2_fp_format': None } diff --git a/shell/option_parser.py b/shell/option_parser.py index 46277be1b..c43e92dc0 100755 --- a/shell/option_parser.py +++ b/shell/option_parser.py @@ -328,9 +328,9 @@ def get_option_parser(defaults): parser.add_option("--hs2_fp_format", type="str", dest="hs2_fp_format", default=None, help="Sets the printing format specification for floating point " - "values when using HS2 protocol. The default behaviour makes the " - "values handled by Python's str() built-in method. Use '%16G' to " - "match Beeswax protocol's floating-point output format") + "values when using the HS2 protocol. The default behaviour makes the " + "values handled by Python's str() built-in method. Use '16G' to " + "match the Beeswax protocol's floating-point output format.") # add default values to the help text for option in parser.option_list:
