This is an automated email from the ASF dual-hosted git repository. joemcdonnell pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit c3e3953e84483a8216cc197aab43b0d2cd46cc8f Author: zhangyifan27 <[email protected]> AuthorDate: Sun Apr 23 11:01:19 2023 +0800 IMPALA-12085: Update comments in cluster-membership-mgr.h As IMPALA-8484 has been resolved, outdated comments in cluster-membership-mgr.h should be removed. This patch contains no functional changes. Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca Reviewed-on: http://gerrit.cloudera.org:8080/19788 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- be/src/scheduling/cluster-membership-mgr.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/be/src/scheduling/cluster-membership-mgr.h b/be/src/scheduling/cluster-membership-mgr.h index 7ce425ce9..ff698f1b5 100644 --- a/be/src/scheduling/cluster-membership-mgr.h +++ b/be/src/scheduling/cluster-membership-mgr.h @@ -56,10 +56,6 @@ class SchedulerWrapper; /// subscriber is recovering from a connection failure. This allows other backends to /// re-register with the statestore after a statestore restart. /// -/// TODO(IMPALA-8484): Allow specifying executor groups during backend startup. Currently -/// only one executor group named "default" exists. All backends are part of that group -/// and it's the only group available for scheduling. -/// /// The class also allows the local backend (ImpalaServer), the local Frontend and the /// AdmissionController to register callbacks to receive notifications of changes to the /// cluster membership. Note: The notifications for blacklisted executors are not sent @@ -79,8 +75,7 @@ class ClusterMembershipMgr { /// Maps backend IDs to backend descriptors. typedef std::unordered_map<std::string, BackendDescriptorPB> BackendIdMap; - /// Maps executor group names to executor groups. For now, only a default group exists - /// and all executors are part of that group. + /// Maps executor group names to executor groups. typedef std::unordered_map<std::string, ExecutorGroup> ExecutorGroups; // A snapshot of the current cluster membership. The ClusterMembershipMgr maintains a
