This is an automated email from the ASF dual-hosted git repository.

wzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 362a8fe6b4c98e20534228f1e5e4f4d0dd9f3ad2
Author: Kurt Deschler <[email protected]>
AuthorDate: Wed May 3 09:15:35 2023 -0500

    IMPALA-12113: Fix elapsed time calculation in query timeline
    
    This patch changes the elapsed time at the bottom of the query timeline
    to show the end of each interval. This was the original intention to use
    the end time and right-align these values so that the full elapsed time
    of the query is shown on the last interval. The query start time is
    always implicitly 0 in the timeline.
    
    Testing: Manually tested query in WebUI
    
    Change-Id: I3ed33f13fbe1bf3e12e149db2e72ddbac0178643
    Reviewed-on: http://gerrit.cloudera.org:8080/19834
    Reviewed-by: Impala Public Jenkins <[email protected]>
    Tested-by: Impala Public Jenkins <[email protected]>
---
 www/query_timeline.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/query_timeline.tmpl b/www/query_timeline.tmpl
index 18e84e5c7..bef1c5bbb 100644
--- a/www/query_timeline.tmpl
+++ b/www/query_timeline.tmpl
@@ -452,7 +452,7 @@ function renderTiming(ignored_arg) {
   var sec_per_tic = maxts / ntics / 1000000000;
   var px_per_tic = chart_width / ntics;
   var x = name_width;
-  for (var i = 0; i < ntics; ++i) {
+  for (var i = 1; i <= ntics; ++i) {
     footer_ctx.fillStyle = "#000000";
     var y = rownum_l * height;
     footer_ctx.fillRect(x, y, px_per_tic, height);

Reply via email to