This is an automated email from the ASF dual-hosted git repository.
michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 8084fe815 IMPALA-12542: Wait for query cancellation in webserver test
8084fe815 is described below
commit 8084fe81525868b17c9ddcb54bbfd78ea81b41fb
Author: Michael Smith <[email protected]>
AuthorDate: Mon Nov 6 13:19:01 2023 -0800
IMPALA-12542: Wait for query cancellation in webserver test
Waits for query cancellation in web cancellation tests as cancellation
may not be finalized when the API returns success in slow environments
(such as ASAN).
Testing: passed 100 iterations with ASAN.
Change-Id: I1c3bc83955be025e83a426377221767694baa444
Reviewed-on: http://gerrit.cloudera.org:8080/20668
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
tests/webserver/test_web_pages.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/webserver/test_web_pages.py
b/tests/webserver/test_web_pages.py
index 15f52ba71..2924ff45a 100644
--- a/tests/webserver/test_web_pages.py
+++ b/tests/webserver/test_web_pages.py
@@ -957,7 +957,10 @@ class TestWebPage(ImpalaTestSuite):
response_json = json.loads(response.text)
assert response_json['contents'] == "Query cancellation successful"
- response_json = self.get_queries()
+ # Cancel request can return before cancellation is finalized. Retry for
slow
+ # environments like ASAN.
+ response_json = self.try_until("query cancellation", self.get_queries,
+ lambda resp: resp['num_in_flight_queries'] == 0)
assert response_json['num_in_flight_queries'] == 0
assert response_json['num_waiting_queries'] == 0
