This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit b094f0e2e7ca32f177b3f065612e8f019f080154 Author: wzhou-code <[email protected]> AuthorDate: Tue Jan 30 16:08:32 2024 -0800 IMPALA-12642 (Part-2): Fixed unit-test to verify query options for JDBC external table Previous patch of IMPALA-12642 added supporting query options for Impala external JDBC table. It added one unit-test to verify query option ENABLED_RUNTIME_FILTER_TYPES by checking the queries in Queries Web page. The test failed on Ubuntu 18.04 since the value of query option is shown as single quoted string, instead of double quoted string. This patch fixed the error. Testing: - Ran tests/custom_cluster/test_ext_data_sources.py on Ubuntu 18.04, and Ubuntu 20.04. Change-Id: I996c8fac038132f2b132d5e6ac36aca1dff59d72 Reviewed-on: http://gerrit.cloudera.org:8080/20978 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: gaurav singh <[email protected]> Reviewed-by: Abhishek Rawat <[email protected]> --- tests/custom_cluster/test_ext_data_sources.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/custom_cluster/test_ext_data_sources.py b/tests/custom_cluster/test_ext_data_sources.py index 137693edb..7ebffa8b0 100644 --- a/tests/custom_cluster/test_ext_data_sources.py +++ b/tests/custom_cluster/test_ext_data_sources.py @@ -238,7 +238,8 @@ class TestImpalaExtJdbcTables(CustomClusterTestSuite): "No matching option MAX_ERRORS found in the queries site." assert "SET MEM_LIMIT=1000000000" in response_json, \ "No matching option MEM_LIMIT found in the queries site." - assert "SET ENABLED_RUNTIME_FILTER_TYPES=\\\"BLOOM,MIN_MAX\\\"" in response_json, \ + assert "SET ENABLED_RUNTIME_FILTER_TYPES=\\\"BLOOM,MIN_MAX\\\"" in response_json or \ + "SET ENABLED_RUNTIME_FILTER_TYPES='BLOOM,MIN_MAX'" in response_json, \ "No matching option ENABLED_RUNTIME_FILTER_TYPES found in the queries site." assert "SET QUERY_TIMEOUT_S=600" in response_json, \ "No matching option QUERY_TIMEOUT_S found in the queries site."
