This is an automated email from the ASF dual-hosted git repository.

laszlog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 7f190c4625f26cb375c0b0fa504ecb0887a70048
Author: Surya Hebbar <[email protected]>
AuthorDate: Thu Feb 22 12:51:13 2024 +0530

    IMPALA-12823: Fix repeated query not found messages in impalad.INFO logs
    
    If an unknown or closed query id is requested from the impala
    server, the page repeatedly queries the server producing repeated
    query not found messages in the impalad.INFO logs.
    
    The behaviour is seen in query plan and query summary pages.
    
    This has been fixed by stopping further requests on receiving
    an error response from the server.
    
    Change-Id: I6d994482b6f67a2d09c6a924eaaf90b230245b61
    Reviewed-on: http://gerrit.cloudera.org:8080/21052
    Reviewed-by: Impala Public Jenkins <[email protected]>
    Tested-by: Impala Public Jenkins <[email protected]>
---
 www/query_plan.tmpl    | 4 ++++
 www/query_summary.tmpl | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/www/query_plan.tmpl b/www/query_plan.tmpl
index 8d0569b62..519da0cf6 100644
--- a/www/query_plan.tmpl
+++ b/www/query_plan.tmpl
@@ -183,6 +183,10 @@ var is_first = true;
 function renderGraph(ignored_arg) {
   if (req.status != 200) return;
   var json = JSON.parse(req.responseText);
+  if (json.error) {
+    clearInterval(intervalId);
+    return;
+  }
   refresh_record(json.record_json);
   var plan = json["plan_json"];
   var inflight = json["inflight"];
diff --git a/www/query_summary.tmpl b/www/query_summary.tmpl
index a1c6c3192..9258f1da4 100644
--- a/www/query_summary.tmpl
+++ b/www/query_summary.tmpl
@@ -47,6 +47,11 @@ function refresh() {
     }
     var blob = xhr.response;
     json = JSON.parse(blob);
+    if (json.error) {
+      clearInterval(intervalId);
+      document.getElementById("toggle").checked = false;
+      return;
+    }
     refresh_record(json.record_json);
     document.getElementById("timeline").textContent = json["timeline"].trim();
     document.getElementById("summary").textContent = json["summary"].trim();

Reply via email to