This is an automated email from the ASF dual-hosted git repository.
michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 07218588a IMPALA-12362: (part-3/4) Add more binaries to packaging
module.
07218588a is described below
commit 07218588a661bac057857abc8f248228333c49d0
Author: Xiang Yang <[email protected]>
AuthorDate: Fri Jan 19 15:44:41 2024 +0000
IMPALA-12362: (part-3/4) Add more binaries to packaging module.
Add admissiond service and impala-profile-tool to packaging module.
Testing:
- Manually deploy packages on Ubuntu22.04 and verify it.
Change-Id: I594742037a05d4d74d6a2bc011619713f7ca12e4
Reviewed-on: http://gerrit.cloudera.org:8080/20929
Reviewed-by: Quanlong Huang <[email protected]>
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
be/src/service/CMakeLists.txt | 1 +
be/src/util/CMakeLists.txt | 2 ++
package/bin/impala.sh | 11 ++++++-----
package/conf/admissiond_flags | 26 ++++++++++++++++++++++++++
4 files changed, 35 insertions(+), 5 deletions(-)
diff --git a/be/src/service/CMakeLists.txt b/be/src/service/CMakeLists.txt
index 47cceb50a..7f5206d3d 100644
--- a/be/src/service/CMakeLists.txt
+++ b/be/src/service/CMakeLists.txt
@@ -120,6 +120,7 @@ target_link_libraries(impalad
install(FILES ${STATESTORED_SYMLINK} DESTINATION ${IMPALA_INSTALLDIR}/sbin)
install(FILES ${CATALOGD_SYMLINK} DESTINATION ${IMPALA_INSTALLDIR}/sbin)
+install(FILES ${ADMISSIOND_SYMLINK} DESTINATION ${IMPALA_INSTALLDIR}/sbin)
install(TARGETS impalad DESTINATION ${IMPALA_INSTALLDIR}/sbin)
if (BUILD_WITH_NO_TESTS)
diff --git a/be/src/util/CMakeLists.txt b/be/src/util/CMakeLists.txt
index bc77b9291..cf50196ad 100644
--- a/be/src/util/CMakeLists.txt
+++ b/be/src/util/CMakeLists.txt
@@ -159,6 +159,8 @@ add_library(loggingsupport SHARED
add_executable(parquet-reader parquet-reader.cc)
add_executable(impala-profile-tool impala-profile-tool.cc)
+install(TARGETS impala-profile-tool DESTINATION ${IMPALA_INSTALLDIR}/util)
+
target_link_libraries(parquet-reader ${IMPALA_LINK_LIBS})
target_link_libraries(impala-profile-tool ${IMPALA_LINK_LIBS})
diff --git a/package/bin/impala.sh b/package/bin/impala.sh
index f480f5c24..219f7cacb 100755
--- a/package/bin/impala.sh
+++ b/package/bin/impala.sh
@@ -48,7 +48,7 @@ status() {
local service=
while [[ $# -gt 0 ]]; do
case ${1} in
- impalad|catalogd|statestored) service=${1} && shift && break ;;
+ impalad|catalogd|admissiond|statestored) service=${1} && shift && break
;;
*) usage && exit 1 ;;
esac
done
@@ -89,7 +89,7 @@ stop() {
case ${1} in
-c) counts=${2} && shift 2 ;;
-p) period=${2} && shift 2 ;;
- impalad|catalogd|statestored) service=${1} && shift && break ;;
+ impalad|catalogd|admissiond|statestored) service=${1} && shift && break
;;
*) usage && exit 1 ;;
esac
done
@@ -147,7 +147,7 @@ start() {
case ${1} in
-c) counts=${2} && shift 2 ;;
-p) period=${2} && shift 2 ;;
- impalad|catalogd|statestored) service=${1} && shift && break ;;
+ impalad|catalogd|admissiond|statestored) service=${1} && shift && break
;;
*) usage && exit 1 ;;
esac
done
@@ -178,7 +178,7 @@ health() {
case ${1} in
-c) counts=${2} && shift 2 ;;
-p) period=${2} && shift 2 ;;
- impalad|catalogd|statestored) service=${1} && shift ;;
+ impalad|catalogd|admissiond|statestored) service=${1} && shift ;;
*) usage && exit 1 ;;
esac
done
@@ -200,6 +200,7 @@ health() {
case ${service} in
impalad) port=25000;;
catalogd) port=25020;;
+ admissiond) port=25030;;
statestored) port=25010;;
esac
fi
@@ -225,7 +226,7 @@ usage() {
echo " $0 --version"
echo " $0 --help"
echo " command: {start|stop|restart|status|health}"
- echo " service: {impalad|catalogd|statestored}"
+ echo " service: {impalad|catalogd|admissiond|statestored}"
echo " flags: in pattern '-key=val...'."
echo
echo " start: start an Impala daemon service, wait until service is ready."
diff --git a/package/conf/admissiond_flags b/package/conf/admissiond_flags
new file mode 100644
index 000000000..860aa9bda
--- /dev/null
+++ b/package/conf/admissiond_flags
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Specify flags for admissiond.
+
+# -hostname=localhost
+# -log_dir=/var/log/impala
+# -minidump_path=/var/log/impala/minidumps
+-v=1
+-log_filename=admissiond
+-max_log_files=10
+-max_log_size=200