This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new e7dac008b IMPALA-13146: Download NodeJS from native toolchain
e7dac008b is described below
commit e7dac008bbafb20e4c7d15d46fbbbb2bac9a757f
Author: Joe McDonnell <[email protected]>
AuthorDate: Fri Jun 7 12:56:12 2024 -0700
IMPALA-13146: Download NodeJS from native toolchain
Some test runs have had issues downloading the NodeJS
tarball from the nodejs servers. This changes the
test to download from our native toolchain to make this
more reliable. This means that future upgrades to
NodeJS will need to upload new tarballs to the native
toolchain.
Testing:
- Ran x86_64/ARM javascript tests
Change-Id: I1def801469cb68633e89b4a0f3c07a771febe599
Reviewed-on: http://gerrit.cloudera.org:8080/21494
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Surya Hebbar <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
---
tests/run-js-tests.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/run-js-tests.sh b/tests/run-js-tests.sh
index 7f4cf70bb..8e073ff60 100755
--- a/tests/run-js-tests.sh
+++ b/tests/run-js-tests.sh
@@ -51,8 +51,8 @@ if [ -r "$IMPALA_NODEJS" ]; then
echo "NodeJS ${NODEJS_VERSION} installation found";
else
echo "Fetching NodeJS ${NODEJS_VERSION}-${NODEJS_DISTRO} binaries ...";
- NODE_URL_PREFIX="https://nodejs.org/dist";
-
NODE_URL_SUFFIX="${NODEJS_VERSION}/node-${NODEJS_VERSION}-${NODEJS_DISTRO}.tar.xz"
+ NODE_URL_PREFIX="https://${IMPALA_TOOLCHAIN_HOST}/mirror/nodejs";
+ NODE_URL_SUFFIX="node-${NODEJS_VERSION}-${NODEJS_DISTRO}.tar.xz"
curl "${NODE_URL_PREFIX}/${NODE_URL_SUFFIX}" -O
tar -xJf node-${NODEJS_VERSION}-${NODEJS_DISTRO}.tar.xz
