This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit dc26bf2c1225b0d1ea81ce2941a77611658b9b03 Author: Riza Suminto <[email protected]> AuthorDate: Tue Sep 17 13:47:39 2024 -0700 IMPALA-13390: Lower MEM_LIMIT in test_exchange_mem_usage_scaling There have been several improvements in tracking KRPC memory usage, and this test_exchange_mem_usage_scaling is now flaky again for not hitting the "Memory limit exceeded" error. This patch lowers the MEM_LIMIT again to reliably hit memory limit error. Testing: - Loop test_exchange_mem_usage_scaling 100 times. Change-Id: I0a4bbfbec01ae63299d3de049f7766ba2ad0e913 Reviewed-on: http://gerrit.cloudera.org:8080/21817 Reviewed-by: Fang-Yu Rao <[email protected]> Reviewed-by: Wenzhe Zhou <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- .../queries/QueryTest/exchange-mem-scaling.test | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test b/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test index 10c7a951c..0637a5420 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test +++ b/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test @@ -4,12 +4,12 @@ # it hits the memory limit in the exchange node when allocating receiver-side # buffers. It's also possible but less likely that this will hit a memory limit # in the scan nodes. -# IMPALA-9355: An exchange node does not set a memory limit for buffer pool. To -# hit the memory limit exceeding error reliably, the memory limit for the entire query -# has to be set to a value less than 171520k (167.5Mb) which is the minimum for the query -# to be accepted after the result spooling is enabled by default. Disable result spooling -# here by setting spool_query_results to false, and set the query memory limit to 164Mb. -set mem_limit=164m; +# IMPALA-13390: Several improvements have been made in exchange node memory estimate and +# usage. To hit the memory limit exceeding error reliably, the memory limit for the +# entire query has to be set to 156MB, the minimum memory needed to pass admission +# control without result spooling. Disable result spooling here by setting +# spool_query_results to false and set the query memory limit to 156MB. +set mem_limit=156m; set spool_query_results=false; set num_scanner_threads=1; select *
