This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 5e4f882203ba07c467ac1ae2feb5420c0abc9936 Author: Riza Suminto <[email protected]> AuthorDate: Thu Mar 13 12:19:54 2025 -0700 IMPALA-13842: Enable graceful shutdown for test_redaction test_redation in both test_query_live.py and test_query_log.py enables workload management feature, but not followed by enabling graceful shutdown. As consequence, if test cluster is shutting down, HMS lock might still held and not unlocked properly. Other tests that want to write to sys.impala_query_log will not able to obtain the HMS lock needed. This patch fix the issue by enabling graceful shutdown for test_redaction. Testing: - Run and pass the tests. Change-Id: Iefabe07b9d32fbc74957bf3fa1cb8445ad7e2b71 Reviewed-on: http://gerrit.cloudera.org:8080/22621 Reviewed-by: Jason Fehr <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- tests/custom_cluster/test_query_live.py | 1 + tests/custom_cluster/test_query_log.py | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/custom_cluster/test_query_live.py b/tests/custom_cluster/test_query_live.py index 9492d187b..8b3892aac 100644 --- a/tests/custom_cluster/test_query_live.py +++ b/tests/custom_cluster/test_query_live.py @@ -221,6 +221,7 @@ class TestQueryLive(CustomClusterTestSuite): "--redaction_rules_file={}" .format(redaction_rules_file()), catalogd_args="--enable_workload_mgmt", + impalad_graceful_shutdown=True, disable_log_buffering=True) def test_redaction(self): """Asserts the query live table table redacts the statement.""" diff --git a/tests/custom_cluster/test_query_log.py b/tests/custom_cluster/test_query_log.py index 7e4eb2ac2..a27a13c55 100644 --- a/tests/custom_cluster/test_query_log.py +++ b/tests/custom_cluster/test_query_log.py @@ -420,6 +420,7 @@ class TestQueryLogTableBeeswax(TestQueryLogTableBase): "--redaction_rules_file={}" .format(redaction_rules_file()), catalogd_args="--enable_workload_mgmt", + impalad_graceful_shutdown=True, disable_log_buffering=True) def test_redaction(self): """Asserts the query log table redacts the statement."""
