This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 063b90c43 IMPALA-14098: Fix test_pool_config_change_while_queued
063b90c43 is described below
commit 063b90c433e64a5ff881d757d7eca0f2c4521f8f
Author: Riza Suminto <[email protected]>
AuthorDate: Sat May 24 19:46:16 2025 -0700
IMPALA-14098: Fix test_pool_config_change_while_queued
test_pool_config_change_while_queued has been failing for not finding
admission-controller.pool-max-query-mem-limit.root.invalidTestPool
metric reaching 0. This patch increase the mem_limit config in
ResourcePoolConfig.__wait_for_impala_to_pickup_config_change() from 10G
to 20G to ensure that the trigger query is always rejected and refresh
the pool config.
Testing:
Loop the test 10 times in exhaustive mode and pass them all.
Change-Id: If903840f81d54d58947fe596ecc0c86e6a234b60
Reviewed-on: http://gerrit.cloudera.org:8080/22946
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
tests/common/resource_pool_config.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/common/resource_pool_config.py
b/tests/common/resource_pool_config.py
index 162a7b8e0..0c53bbdf0 100644
--- a/tests/common/resource_pool_config.py
+++ b/tests/common/resource_pool_config.py
@@ -65,7 +65,7 @@ class ResourcePoolConfig(object):
client.set_configuration_option('request_pool', pool_name)
# set mem_limit to something above the proc limit so that the query always
gets
# rejected.
- client.set_configuration_option('mem_limit', '10G')
+ client.set_configuration_option('mem_limit', '20G')
metric_key = "admission-controller.{0}.root.{1}".format(metric_str,
pool_name)
start_time = time()
while (time() - start_time < timeout):
@@ -76,6 +76,7 @@ class ResourcePoolConfig(object):
if current_val == target_val:
return
sleep(0.1)
+ client.close()
assert False, "Timed out waiting for {0} to reach {1}. Current:
{2}".format(
metric_key, target_val, current_val)
