This is an automated email from the ASF dual-hosted git repository.
michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 8a93caf8848103f9b9f0631a91daeeb9056711ce
Author: Riza Suminto <riza.sumi...@cloudera.com>
AuthorDate: Mon Jun 9 14:35:31 2025 -0700
IMPALA-14135: Skip Calcite planner test if TARGET_FILESYSTEM=s3
org.apache.impala.calcite.planner.TpcdsCpuCostPlannerTest fail in S3
build. This test should be skipped in S3, just like the original
org.apache.impala.planner.TpcdsCpuCostPlannerTest. See also IMPALA-8944
on why some tests are skipped in S3.
This patch also move Calcite FE tests ahead of FE custom cluster tests
so that Calcite JAR is available for later tests.
Change-Id: I8d04915de3eb4c81f7d63f61c1b1d804c9fcd941
Reviewed-on: http://gerrit.cloudera.org:8080/22998
Reviewed-by: Michael Smith <michael.sm...@cloudera.com>
Tested-by: Michael Smith <michael.sm...@cloudera.com>
---
bin/run-all-tests.sh | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/bin/run-all-tests.sh b/bin/run-all-tests.sh
index 5c8b28187..7ba2dbefd 100755
--- a/bin/run-all-tests.sh
+++ b/bin/run-all-tests.sh
@@ -307,6 +307,17 @@ do
TEST_RET_CODE=1
fi
+ pushd ${IMPALA_HOME}/java/calcite-planner
+ # Install Calcite FE jar
+ "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae install -DskipTests
+ if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then
+ # Run Calcite FE tests
+ if ! "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae test install ; then
+ TEST_RET_CODE=1
+ fi
+ fi
+ popd
+
# Run the FE custom cluster tests only if not running against S3
if [[ "${TARGET_FILESYSTEM}" != "s3" ]]; then
MVN_ARGS=$MVN_ARGS_TEMP
@@ -319,13 +330,6 @@ do
fi
popd
- # Run Calcite FE tests
- pushd ${IMPALA_HOME}/java/calcite-planner
- if ! "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae test install ; then
- TEST_RET_CODE=1
- fi
- popd
-
# Restore old (likely empty) JAVA_TOOL_OPTIONS to avoid polluting other
tests.
export JAVA_TOOL_OPTIONS=$PREV_JAVA_TOOL_OPTIONS
fi
