This is an automated email from the ASF dual-hosted git repository. stigahuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/impala.git
commit 96a3b09964ed945409cc7ec3d423c969166d57b7 Author: Yida Wu <[email protected]> AuthorDate: Wed Jan 21 00:51:50 2026 -0800 IMPALA-14267: Reduce log frequency when dequeuing fails When the admission controller fails to dequeue queries, like when at capacity, it logs a message on every retry loop. This can cause excessive logs, like ten per second until queuing timeout. This patch reduces the log frequency to once every 5 seconds using KLOG_EVERY_N_SECS. This prevents too many logs while keeping the message visible when admission control is at capacity. This also changes the dequeuing fails log level from VLOG(1) to INFO because the macro uses a standard log level, but this is safe because the log rate is under control now. Testing: Verified logs are throttled to 5s intervals when the queue is full. Change-Id: I682b4416a2255f5be6480a7db8835f6aa54477bb Reviewed-on: http://gerrit.cloudera.org:8080/23881 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- be/src/scheduling/admission-controller.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/be/src/scheduling/admission-controller.cc b/be/src/scheduling/admission-controller.cc index a879d85fa..4fa8f4f37 100644 --- a/be/src/scheduling/admission-controller.cc +++ b/be/src/scheduling/admission-controller.cc @@ -23,6 +23,7 @@ #include "common/logging.h" #include "common/names.h" +#include "kudu/util/logging.h" #include "runtime/bufferpool/reservation-util.h" #include "runtime/exec-env.h" #include "runtime/mem-tracker.h" @@ -2715,8 +2716,9 @@ int64_t AdmissionController::GetMaxToDequeue( void AdmissionController::LogDequeueFailed( QueueNode* node, const string& not_admitted_reason) { - VLOG_QUERY << "Could not dequeue query id=" << PrintId(node->admission_request.query_id) - << " reason: " << not_admitted_reason; + KLOG_EVERY_N_SECS(INFO, 5) << "Could not dequeue query id=" + << PrintId(node->admission_request.query_id) + << " reason: " << not_admitted_reason; node->admission_request.summary_profile->AddInfoString( PROFILE_INFO_KEY_LAST_QUEUED_REASON, not_admitted_reason); }
