(impala) branch master updated: IMPALA-14691: Only log modified query options

[joemcdonnell]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new e36d717eb IMPALA-14691: Only log modified query options
e36d717eb is described below

commit e36d717eb6165f42fafc8407a291e00bb0ee1169
Author: Balazs Hevele <bhev...@cloudera.com>
AuthorDate: Mon Feb 23 13:04:25 2026 +0100

    IMPALA-14691: Only log modified query options
    
    Instead of always logging every query option as a key value pair,
    only log the ones differing from their default values as defined
    in TQueryOptions.
    
    Most of the time, most, if not all, query options are not overridden,
    and use the default value. Logging only the modified values gives a
    shorter and more understandable information, as the full list is very
    long.
    
    A function to extract the necessary list of modified values already
    exists (DebugQueryOptions), and is used e.g. in query profile.
    
    An example to the per query log, with one option changed:
      TClientRequest.queryOptions: ABORT_ON_ERROR=1
    
    The list of changed query options will be listed independently of
    where the set happens. For example, both values set with
    --default_query_options startup param, and values changed with SET
    inside impala shell will be listed if different from default value
    in TQueryOptions.
    
    Change-Id: Ibcd9eb80afaa3171f5436cabb4703bbae4581396
    Reviewed-on: http://gerrit.cloudera.org:8080/24022
    Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
    Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
 be/src/service/impala-beeswax-server.cc | 2 +-
 be/src/service/impala-hs2-server.cc     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/be/src/service/impala-beeswax-server.cc 
b/be/src/service/impala-beeswax-server.cc
index 1fe84f97d..774236085 100644
--- a/be/src/service/impala-beeswax-server.cc
+++ b/be/src/service/impala-beeswax-server.cc
@@ -603,7 +603,7 @@ Status ImpalaServer::QueryToTQueryContext(const Query& 
query,
   // pool options.
   AddPoolConfiguration(query_ctx, ~set_query_options_mask);
   VLOG_QUERY << "TClientRequest.queryOptions: "
-             << ThriftDebugString(query_ctx->client_request.query_options);
+             << DebugQueryOptions(query_ctx->client_request.query_options);
   return Status::OK();
 }
 
diff --git a/be/src/service/impala-hs2-server.cc 
b/be/src/service/impala-hs2-server.cc
index b6dfddc53..472f19c00 100644
--- a/be/src/service/impala-hs2-server.cc
+++ b/be/src/service/impala-hs2-server.cc
@@ -295,7 +295,7 @@ Status ImpalaServer::TExecuteStatementReqToTQueryContext(
   // pool options.
   AddPoolConfiguration(query_ctx, ~set_query_options_mask);
   VLOG_QUERY << "TClientRequest.queryOptions: "
-             << ThriftDebugString(query_ctx->client_request.query_options);
+             << DebugQueryOptions(query_ctx->client_request.query_options);
   return Status::OK();
 }