IMPALA-3753: Disable create table test for old aggs and joins The "IMPALA-3530: Clean up test_ddl.py. Part 1." (7ed744e) commit made it so that a query referencing nested types is run as part of the create table test, which caused the OldAggsJoins build to fail. This commit disables the create table test for the OldAggsJoins build since it does not provide any meaningful coverage anyways.
Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c Reviewed-on: http://gerrit.cloudera.org:8080/3430 Reviewed-by: Taras Bobrovytsky <[email protected]> Tested-by: Taras Bobrovytsky <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/7e4aacdf Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/7e4aacdf Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/7e4aacdf Branch: refs/heads/master Commit: 7e4aacdf611edf69f4905a9a52fd9f7df6144a1c Parents: a5ae2bf Author: Taras Bobrovytsky <[email protected]> Authored: Tue Jun 21 16:07:34 2016 -0700 Committer: Tim Armstrong <[email protected]> Committed: Wed Jun 22 23:39:12 2016 -0700 ---------------------------------------------------------------------- tests/common/skip.py | 8 ++++++-- tests/metadata/test_ddl.py | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/7e4aacdf/tests/common/skip.py ---------------------------------------------------------------------- diff --git a/tests/common/skip.py b/tests/common/skip.py index ab95904..1fb6ee7 100644 --- a/tests/common/skip.py +++ b/tests/common/skip.py @@ -22,8 +22,12 @@ import os import pytest from functools import partial from tests.common.environ import IMPALAD_BUILD, USING_OLD_AGGS_JOINS -from tests.util.filesystem_utils import IS_DEFAULT_FS, IS_S3, IS_ISILON, IS_LOCAL,\ - SECONDARY_FILESYSTEM +from tests.util.filesystem_utils import ( + IS_DEFAULT_FS, + IS_ISILON, + IS_LOCAL, + IS_S3, + SECONDARY_FILESYSTEM) class SkipIfS3: http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/7e4aacdf/tests/metadata/test_ddl.py ---------------------------------------------------------------------- diff --git a/tests/metadata/test_ddl.py b/tests/metadata/test_ddl.py index d4c99a2..e446b2f 100644 --- a/tests/metadata/test_ddl.py +++ b/tests/metadata/test_ddl.py @@ -17,7 +17,7 @@ import time import getpass from tests.common.test_vector import * from tests.common.impala_test_suite import * -from tests.common.skip import SkipIf, SkipIfS3, SkipIfIsilon, SkipIfLocal, SkipIfOldAggsJoins +from tests.common.skip import SkipIf, SkipIfLocal, SkipIfOldAggsJoins from tests.util.filesystem_utils import WAREHOUSE, IS_LOCAL from test_ddl_base import TestDdlBase @@ -195,6 +195,11 @@ class TestDdlStatements(TestDdlBase): self.run_test_case('QueryTest/create-database', vector, multiple_impalad=self._use_multiple_impalad(vector)) + # There is a query in QueryTest/create-table that references nested types, which is not + # supported if old joins and aggs are enabled. Since we do not get any meaningful + # additional coverage by running a DDL test under the old aggs and joins, it can be + # skipped. + @SkipIfOldAggsJoins.nested_types @pytest.mark.execute_serially def test_create_table(self, vector): vector.get_value('exec_option')['abort_on_error'] = False
