Repository: incubator-impala Updated Branches: refs/heads/master 65806e200 -> b94f88a69
IMPALA-3886: Improve log of pip_download.py pip_download.py prints the following line for each dependency that is already up-to-date: File with matching md5sum already exists, skipping download. This change adds the filename to the message so it is more useful. Change-Id: Ie3d81743814be37ee8ddbe04c264ed2bf37410f9 Reviewed-on: http://gerrit.cloudera.org:8080/3687 Reviewed-by: Lars Volker <[email protected]> Reviewed-by: Taras Bobrovytsky <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/b94f88a6 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/b94f88a6 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/b94f88a6 Branch: refs/heads/master Commit: b94f88a697e0bf989b2a5392e1bddc105195cbf4 Parents: 65806e2 Author: Lars Volker <[email protected]> Authored: Wed Jul 20 17:11:32 2016 +0200 Committer: Tim Armstrong <[email protected]> Committed: Thu Jul 21 08:30:51 2016 -0700 ---------------------------------------------------------------------- infra/python/deps/pip_download.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/b94f88a6/infra/python/deps/pip_download.py ---------------------------------------------------------------------- diff --git a/infra/python/deps/pip_download.py b/infra/python/deps/pip_download.py index a3268b6..bad1d20 100755 --- a/infra/python/deps/pip_download.py +++ b/infra/python/deps/pip_download.py @@ -59,7 +59,7 @@ def download_package(pkg_name, pkg_version): filename = pkg['filename'] expected_md5 = pkg['md5_digest'] if os.path.isfile(filename) and check_md5sum(filename, expected_md5): - print "File with matching md5sum already exists, skipping download." + print "File with matching md5sum already exists, skipping %s" % filename return True print "Downloading %s from %s " % (filename, pkg['url']) downloader.retrieve(pkg['url'], filename)
