Repository: incubator-impala Updated Branches: refs/heads/master f60b2beb8 -> a7963e6b0
IMPALA-3914: SKIP_TOOLCHAIN_BOOTSTRAP skips Python package downloads SKIP_TOOLCHAIN_BOOTSTRAP is meant to control download of third-party components to speed up builds and allow builds to be less tied to third-party infrastructure. It therefore makes sense that it should apply to downloading of third-party Python packages. Change-Id: Ibf68dbf5efb514511fc16e2956284ce508b997aa Reviewed-on: http://gerrit.cloudera.org:8080/3773 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/a7963e6b Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/a7963e6b Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/a7963e6b Branch: refs/heads/master Commit: a7963e6b03f5dc21600ee148f8fb62cc6ac1df80 Parents: f60b2be Author: Tim Armstrong <[email protected]> Authored: Tue Jul 26 09:52:33 2016 -0700 Committer: Internal Jenkins <[email protected]> Committed: Thu Jul 28 03:45:45 2016 +0000 ---------------------------------------------------------------------- buildall.sh | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/a7963e6b/buildall.sh ---------------------------------------------------------------------- diff --git a/buildall.sh b/buildall.sh index 6944169..3c60395 100755 --- a/buildall.sh +++ b/buildall.sh @@ -239,16 +239,6 @@ if [[ -z $METASTORE_SNAPSHOT_FILE && "${TARGET_FILESYSTEM}" != "hdfs" && exit 1 fi -echo "Downloading Python dependencies" -# Download all the Python dependencies we need before doing anything -# of substance. Does not re-download anything that is already present. -if ! $IMPALA_HOME/infra/python/deps/download_requirements; then - echo "Warning: Unable to download Python requirements." - echo "Warning: bootstrap_virtualenv or other Python-based tooling may fail." -else - echo "Finished downloading Python dependencies" -fi - # option to clean everything first if [ $CLEAN_ACTION -eq 1 ]; then $IMPALA_HOME/bin/clean.sh @@ -256,8 +246,19 @@ fi # Populate necessary thirdparty components unless it's set to be skipped. if [ "${SKIP_TOOLCHAIN_BOOTSTRAP}" = true ]; then + echo "SKIP_TOOLCHAIN_BOOTSTRAP is true, skipping download of Python dependencies." echo "SKIP_TOOLCHAIN_BOOTSTRAP is true, skipping toolchain bootstrap." else + echo "Downloading Python dependencies" + # Download all the Python dependencies we need before doing anything + # of substance. Does not re-download anything that is already present. + if ! $IMPALA_HOME/infra/python/deps/download_requirements; then + echo "Warning: Unable to download Python requirements." + echo "Warning: bootstrap_virtualenv or other Python-based tooling may fail." + else + echo "Finished downloading Python dependencies" + fi + echo "Downloading and extracting toolchain dependencies." $IMPALA_HOME/bin/bootstrap_toolchain.py echo "Toolchain bootstrap complete."
