Repository: incubator-impala
Updated Branches:
  refs/heads/master f7bf59f5c -> 0e886618e


Stricter clang-format: set DerivePointerAlignment to false.

The description of DerivePointerAlignment, which is set to true in the
Google style, is

   If true, analyze the formatted file for the most common alignment
   of & and *. PointerAlignment is then used only as fallback.

(PointerAlignment is Left, meaning "char* x".)

The virtue of setting DerivePointerAlignment to false is that it will
prevent new contributors from setting the pointers in the wrong place
in a new file or in a file they are modifying heavily.

Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6
Reviewed-on: http://gerrit.cloudera.org:8080/4127
Reviewed-by: Jim Apple <[email protected]>
Tested-by: Internal Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/9f2c42dd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/9f2c42dd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/9f2c42dd

Branch: refs/heads/master
Commit: 9f2c42ddc8ead58d96143cae27174b02c8c96aa0
Parents: f7bf59f
Author: Jim Apple <[email protected]>
Authored: Thu Aug 25 14:23:28 2016 -0700
Committer: Internal Jenkins <[email protected]>
Committed: Fri Aug 26 02:04:28 2016 +0000

----------------------------------------------------------------------
 .clang-format | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/9f2c42dd/.clang-format
----------------------------------------------------------------------
diff --git a/.clang-format b/.clang-format
index 6d31ebc..2de4b96 100644
--- a/.clang-format
+++ b/.clang-format
@@ -8,6 +8,7 @@ BreakBeforeTernaryOperators: 'false'
 ColumnLimit: '90'
 ConstructorInitializerIndentWidth: '2'
 ContinuationIndentWidth: '4'
+DerivePointerAlignment: 'false'
 PenaltyBreakBeforeFirstCallParameter: '99999999'
 SpacesBeforeTrailingComments: '1'
 Standard: 'Cpp11'
\ No newline at end of file

Reply via email to