Remove spurious Boost warnings on compilation errors Compilation errors can spuriously print warnings from Boost where the filesystem module is used, like:
âboost::system::posix_categoryâ defined but not used Defining BOOST_SYSTEM_NO_DEPRECATED removes those warnings, which arise from Boost maintaining deprecated names for error codes that have moved namespaces during the shift to C++11 (see http://www.boost.org/doc/libs/1_61_0/boost/system/error_code.hpp and http://www.boost.org/doc/libs/1_61_0/libs/system/doc/reference.html). We're not using the old names, so it's ok to remove them. Change-Id: Ib84d8a9958469fb22b0af4907958917a65e8290f Reviewed-on: http://gerrit.cloudera.org:8080/4564 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/f640b3a3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/f640b3a3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/f640b3a3 Branch: refs/heads/master Commit: f640b3a392dd954f65ab73be14b3670ae57ace29 Parents: b2c2fe7 Author: Henry Robinson <[email protected]> Authored: Thu Sep 29 11:18:29 2016 -0700 Committer: Internal Jenkins <[email protected]> Committed: Thu Sep 29 22:29:37 2016 +0000 ---------------------------------------------------------------------- be/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/f640b3a3/be/CMakeLists.txt ---------------------------------------------------------------------- diff --git a/be/CMakeLists.txt b/be/CMakeLists.txt index 2546bd0..a5cc4d8 100644 --- a/be/CMakeLists.txt +++ b/be/CMakeLists.txt @@ -44,6 +44,7 @@ SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing") SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=c++14") SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-deprecated -Wno-vla") SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG") +SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -DBOOST_SYSTEM_NO_DEPRECATED") SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -B $ENV{IMPALA_TOOLCHAIN}/binutils-$ENV{IMPALA_BINUTILS_VERSION}/bin/") IF($ENV{USE_GOLD_LINKER} STREQUAL "true") SET(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wl,-fuse-ld=gold")
