Repository: incubator-impala Updated Branches: refs/heads/master dead771d1 -> 81c5b8150
IMPALA-4330: Fix JSON syntax in generate_metrics.py The hardcoded JSON string in MDL_BASE had a superfluous comma, that tripped both the simplejson and json parsers. This change removes it so the string works with both parsers. Change-Id: I98456df28d48ed22cefcc570e88df78fdf441c23 Reviewed-on: http://gerrit.cloudera.org:8080/4887 Reviewed-by: Michael Brown <[email protected]> Reviewed-by: Jim Apple <[email protected]> Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/dba30cc2 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/dba30cc2 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/dba30cc2 Branch: refs/heads/master Commit: dba30cc29b4ddcec0f735dcabee6a74ae9534eff Parents: dead771 Author: Lars Volker <[email protected]> Authored: Sun Oct 30 18:00:09 2016 -0700 Committer: Internal Jenkins <[email protected]> Committed: Wed Nov 2 20:01:58 2016 +0000 ---------------------------------------------------------------------- common/thrift/generate_metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/dba30cc2/common/thrift/generate_metrics.py ---------------------------------------------------------------------- diff --git a/common/thrift/generate_metrics.py b/common/thrift/generate_metrics.py index f1f57cd..8d1a82f 100755 --- a/common/thrift/generate_metrics.py +++ b/common/thrift/generate_metrics.py @@ -165,7 +165,7 @@ MDL_BASE = """ { "name" : "CATALOGSERVER", "nameForCrossEntityAggregateMetrics" : "catalogservers" - }, + } ], "metricEntityTypeDefinitions" : [ {
