IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer Change-Id: I52e1b1354e9ea056b49331e75e53759952a81b76 Reviewed-on: http://gerrit.cloudera.org:8080/4835 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5f27ae0c Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5f27ae0c Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5f27ae0c Branch: refs/heads/master Commit: 5f27ae0c2f16b56673f7710b619549b3e54c64bb Parents: 1cfe77d Author: Zoltan Ivanfi <[email protected]> Authored: Tue Oct 25 17:04:58 2016 +0200 Committer: Internal Jenkins <[email protected]> Committed: Fri Nov 4 21:07:08 2016 +0000 ---------------------------------------------------------------------- be/src/exec/hdfs-parquet-table-writer.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5f27ae0c/be/src/exec/hdfs-parquet-table-writer.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/hdfs-parquet-table-writer.cc b/be/src/exec/hdfs-parquet-table-writer.cc index d4aa197..cc708ab 100644 --- a/be/src/exec/hdfs-parquet-table-writer.cc +++ b/be/src/exec/hdfs-parquet-table-writer.cc @@ -509,10 +509,8 @@ Status HdfsParquetTableWriter::BaseColumnWriter::Flush(int64_t* file_pos, for (int i = 0; i < num_data_pages_; ++i) { DataPage& page = pages_[i]; - // Last page might be empty if (page.header.data_page_header.num_values == 0) { - DCHECK_EQ(page.header.compressed_page_size, 0); - DCHECK_EQ(i, num_data_pages_ - 1); + // Skip empty pages continue; }
