IMPALA-4433: Always generate testdata using the same time zone setting Before this change, testdata was generated using the java.util.TimeZone.getDefault() TimeZone of the machine it was running on. This patch standardizes on "America/Los_Angeles", which matches the existing expected results in the end-to-end tests.
Change-Id: Iaf7cc796e44e9ff64880f9ae852f40961592f279 Reviewed-on: http://gerrit.cloudera.org:8080/5058 Reviewed-by: Jim Apple <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/0ea4a666 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/0ea4a666 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/0ea4a666 Branch: refs/heads/hadoop-next Commit: 0ea4a666dc12e093cc12ca4cd640f0ede51661a2 Parents: f4a5d86 Author: Jim Apple <[email protected]> Authored: Fri Nov 11 12:05:30 2016 -0800 Committer: Internal Jenkins <[email protected]> Committed: Tue Nov 15 04:18:33 2016 +0000 ---------------------------------------------------------------------- .../java/org/apache/impala/datagenerator/TestDataGenerator.java | 5 +++++ 1 file changed, 5 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/0ea4a666/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java ---------------------------------------------------------------------- diff --git a/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java b/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java index 7753ac0..29fd0d7 100644 --- a/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java +++ b/testdata/src/main/java/org/apache/impala/datagenerator/TestDataGenerator.java @@ -25,6 +25,7 @@ import java.math.BigDecimal; import java.text.SimpleDateFormat; import java.util.Calendar; import java.util.GregorianCalendar; +import java.util.TimeZone; class TestDataGenerator { // 2 years @@ -152,6 +153,10 @@ class TestDataGenerator { System.err.println("Usage: " + "TestDataGenerator BaseOutputDirectory"); } + // The TimeZone should be the same no matter what the TimeZone is of the computer + // running this code, in order to ensure the generated data is always the same. + TimeZone.setDefault(TimeZone.getTimeZone("America/Los_Angeles")); + // Generate AllTypes String dirName = args[0] + "/AllTypes"; File dir = new File(dirName);
