Repository: incubator-impala Updated Branches: refs/heads/master e2cde13a2 -> 26805809f
IMPALA-4542: Fix use-after-free in some BE tests Change RuntimeState::ReleaseResources() to use cached ExecEnv pointer, rather than singleton. Change-Id: I5302d665756183289edf227588da1c094e197584 Testing: Ran affected BE tests under ASAN. Reviewed-on: http://gerrit.cloudera.org:8080/5243 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/8adc49e5 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/8adc49e5 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/8adc49e5 Branch: refs/heads/master Commit: 8adc49e51c44aa3a4b5334a93b64ae5a21e400b9 Parents: e2cde13 Author: Henry Robinson <[email protected]> Authored: Mon Nov 28 10:49:29 2016 -0800 Committer: Internal Jenkins <[email protected]> Committed: Tue Nov 29 16:36:43 2016 +0000 ---------------------------------------------------------------------- be/src/runtime/runtime-state.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/8adc49e5/be/src/runtime/runtime-state.cc ---------------------------------------------------------------------- diff --git a/be/src/runtime/runtime-state.cc b/be/src/runtime/runtime-state.cc index d0e1172..7954f22 100644 --- a/be/src/runtime/runtime-state.cc +++ b/be/src/runtime/runtime-state.cc @@ -311,7 +311,7 @@ void RuntimeState::ReleaseResources() { if (desc_tbl_ != nullptr) desc_tbl_->ClosePartitionExprs(this); if (filter_bank_ != nullptr) filter_bank_->Close(); if (resource_pool_ != nullptr) { - ExecEnv::GetInstance()->thread_mgr()->UnregisterPool(resource_pool_); + exec_env_->thread_mgr()->UnregisterPool(resource_pool_); } } }
