Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""
Reverting until we have a fix for KUDU-1869: Scans do not work with hybrid time disabled and snapshot reads enabled This reverts commit 32ff959814646458a34278500bd01fc7741951ce. Change-Id: I995dec543946c9e0f79bc5b7e82568060a9d8262 Reviewed-on: http://gerrit.cloudera.org:8080/5970 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/bd1d445b Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/bd1d445b Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/bd1d445b Branch: refs/heads/master Commit: bd1d445b37f3cfc56ff868a678caf161b29a9d92 Parents: ffd297b Author: Matthew Jacobs <[email protected]> Authored: Fri Feb 10 14:21:32 2017 -0800 Committer: Impala Public Jenkins <[email protected]> Committed: Wed Feb 15 22:45:50 2017 +0000 ---------------------------------------------------------------------- be/src/exec/kudu-scanner.cc | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/bd1d445b/be/src/exec/kudu-scanner.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/kudu-scanner.cc b/be/src/exec/kudu-scanner.cc index 8b6778f..d251eba 100644 --- a/be/src/exec/kudu-scanner.cc +++ b/be/src/exec/kudu-scanner.cc @@ -44,9 +44,8 @@ using kudu::client::KuduScanBatch; using kudu::client::KuduSchema; using kudu::client::KuduTable; -DEFINE_string(kudu_read_mode, "READ_AT_SNAPSHOT", "(Advanced) Sets the Kudu scan " - "ReadMode. Supported Kudu read modes are READ_LATEST and READ_AT_SNAPSHOT. Invalid " - "values result in using READ_AT_SNAPSHOT."); +DEFINE_string(kudu_read_mode, "READ_LATEST", "(Advanced) Sets the Kudu scan ReadMode. " + "Supported Kudu read modes are READ_LATEST and READ_AT_SNAPSHOT."); DEFINE_bool(pick_only_leaders_for_tests, false, "Whether to pick only leader replicas, for tests purposes only."); DEFINE_int32(kudu_scanner_keep_alive_period_sec, 15, @@ -57,7 +56,7 @@ DECLARE_int32(kudu_operation_timeout_ms); namespace impala { -const string MODE_READ_LATEST = "READ_LATEST"; +const string MODE_READ_AT_SNAPSHOT = "READ_AT_SNAPSHOT"; KuduScanner::KuduScanner(KuduScanNode* scan_node, RuntimeState* state) : scan_node_(scan_node), @@ -138,9 +137,9 @@ Status KuduScanner::OpenNextScanToken(const string& scan_token) { "Could not set replica selection."); } kudu::client::KuduScanner::ReadMode mode = - MODE_READ_LATEST == FLAGS_kudu_read_mode ? - kudu::client::KuduScanner::READ_LATEST : - kudu::client::KuduScanner::READ_AT_SNAPSHOT; + MODE_READ_AT_SNAPSHOT == FLAGS_kudu_read_mode ? + kudu::client::KuduScanner::READ_AT_SNAPSHOT : + kudu::client::KuduScanner::READ_LATEST; KUDU_RETURN_IF_ERROR(scanner_->SetReadMode(mode), "Could not set scanner ReadMode"); KUDU_RETURN_IF_ERROR(scanner_->SetTimeoutMillis(FLAGS_kudu_operation_timeout_ms), "Could not set scanner timeout");
