http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java b/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java index 667da34..65902ac 100644 --- a/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java +++ b/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java @@ -82,10 +82,6 @@ public class AvroSchemaConverter { return converter.convertFieldSchemasImpl(fieldSchemas, schemaName); } - public static Schema convertTable(Table impalaTable) { - return convertColumns(impalaTable.getColumns(), impalaTable.getFullName()); - } - private Schema convertColumnsImpl(List<Column> columns, String schemaName) { List<Schema.Field> avroFields = Lists.newArrayList(); for (Column column: columns) {
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java b/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java index a52ad91..1846834 100644 --- a/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java +++ b/fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java @@ -408,15 +408,6 @@ public class HdfsCachingUtil { } /** - * Check if the poolName matches the pool of the cache directive - * identified by directiveId - */ - public static boolean isSamePool(String poolName, Long directiveId) - throws ImpalaRuntimeException { - return poolName.equals(getCachePool(directiveId)); - } - - /** * Helper method for frequent lookup of replication factor in the thrift caching * structure. */ http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/KuduUtil.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/KuduUtil.java b/fe/src/main/java/org/apache/impala/util/KuduUtil.java index 75b11b6..073cf70 100644 --- a/fe/src/main/java/org/apache/impala/util/KuduUtil.java +++ b/fe/src/main/java/org/apache/impala/util/KuduUtil.java @@ -308,18 +308,6 @@ public class KuduUtil { Type.fromThrift(boundaryVal.getType()).toSql())); } - /** - * Parses a string of the form "a, b, c" and returns a set of values split by ',' and - * stripped of the whitespace. - */ - public static HashSet<String> parseKeyColumns(String cols) { - return Sets.newHashSet(Splitter.on(",").trimResults().split(cols.toLowerCase())); - } - - public static List<String> parseKeyColumnsAsList(String cols) { - return Lists.newArrayList(Splitter.on(",").trimResults().split(cols.toLowerCase())); - } - public static boolean isSupportedKeyType(org.apache.impala.catalog.Type type) { return type.isIntegerType() || type.isStringType(); } http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/NativeLogger.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/NativeLogger.java b/fe/src/main/java/org/apache/impala/util/NativeLogger.java index ebba884..fc5b169 100644 --- a/fe/src/main/java/org/apache/impala/util/NativeLogger.java +++ b/fe/src/main/java/org/apache/impala/util/NativeLogger.java @@ -25,7 +25,6 @@ import org.slf4j.LoggerFactory; * log4j log messages to be logged by glog. */ public class NativeLogger { - private final static Logger LOG = LoggerFactory.getLogger(NativeLogger.class); private static boolean loaded_ = false; // Writes a log message to glog http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/RequestPoolService.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/RequestPoolService.java b/fe/src/main/java/org/apache/impala/util/RequestPoolService.java index 1443e68..9976623 100644 --- a/fe/src/main/java/org/apache/impala/util/RequestPoolService.java +++ b/fe/src/main/java/org/apache/impala/util/RequestPoolService.java @@ -107,9 +107,6 @@ public class RequestPoolService { // llama-site.xml but is Impala-specific and Llama does not use this. final static String QUEUE_TIMEOUT_KEY = "impala.admission-control.pool-queue-timeout-ms"; - // Default value of the pool queue timeout (ms). - final static int QUEUE_TIMEOUT_MS_DEFAULT = 60 * 1000; - // Key for the pool default query options. Query options are specified as a // comma delimited string of 'key=value' pairs, e.g. 'key1=val1,key2=val2'. // This is specified in the llama-site.xml but is Impala-specific and Llama does not http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java ---------------------------------------------------------------------- diff --git a/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java b/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java index a1290cc..65a443c 100644 --- a/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java +++ b/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java @@ -297,14 +297,6 @@ public class SentryPolicyService { } /** - * Revokes a privilege from an existing role. - */ - public void revokeRolePrivilege(User requestingUser, String roleName, - TPrivilege privilege) throws ImpalaException { - revokeRolePrivileges(requestingUser, roleName, Lists.newArrayList(privilege)); - } - - /** * Revokes privileges from an existing role. * * @param requestingUser - The requesting user. @@ -390,26 +382,6 @@ public class SentryPolicyService { } /** - * Lists all roles granted to all groups a user belongs to. - */ - public List<TSentryRole> listUserRoles(User requestingUser) - throws ImpalaException { - SentryServiceClient client = new SentryServiceClient(); - try { - return Lists.newArrayList(client.get().listUserRoles( - requestingUser.getShortName())); - } catch (SentryAccessDeniedException e) { - throw new AuthorizationException(String.format(ACCESS_DENIED_ERROR_MSG, - requestingUser.getName(), "LIST_USER_ROLES")); - } catch (SentryUserException e) { - throw new InternalException( - "Error making 'listUserRoles' RPC to Sentry Service: ", e); - } finally { - client.close(); - } - } - - /** * Lists all roles. */ public List<TSentryRole> listAllRoles(User requestingUser) throws ImpalaException { http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java ---------------------------------------------------------------------- diff --git a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java index 25ec45c..dfc2580 100644 --- a/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java +++ b/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java @@ -80,10 +80,6 @@ import com.google.common.collect.Maps; @RunWith(Parameterized.class) public class AuthorizationTest { - - private final static Logger LOG = - LoggerFactory.getLogger(AuthorizationTest.class); - // Policy file has defined current user and 'test_user' have: // ALL permission on 'tpch' database and 'newdb' database // ALL permission on 'functional_seq_snap' database http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/71eb569f/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java ---------------------------------------------------------------------- diff --git a/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java b/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java index f571ebe..49f0188 100644 --- a/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java +++ b/fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java @@ -37,9 +37,6 @@ public class S3PlannerTest extends PlannerTestBase { // The path that will replace the value of TEST_FS_S3A_NAME in file paths. private static final Path S3A_CANONICAL_BUCKET = new Path("s3a://bucket"); - // The Hadoop configuration. - private final Configuration CONF = new Configuration(); - // The value of the FILESYSTEM_PREFIX environment variable. private Path fsName;
