IMPALA-5156: Drop VLOG level passed into Kudu client The Kudu logging is very verbose and all of the logging may affect performance. This change reduces the Kudu client log level to v-1, since Impala is typically run at v=1 and isn't too noisy.
In some simple concurrency testing, Todd found that reducing the vlog level resulted in an increase in throughput from ~17 qps to 60qps. Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1 Reviewed-on: http://gerrit.cloudera.org:8080/6549 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Impala Public Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/676a88f3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/676a88f3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/676a88f3 Branch: refs/heads/master Commit: 676a88f346c3dac57ffe0b5742a64ee7136b6bb1 Parents: cfcb5f4 Author: Matthew Jacobs <[email protected]> Authored: Tue Apr 4 13:36:01 2017 -0700 Committer: Impala Public Jenkins <[email protected]> Committed: Wed Apr 5 04:52:59 2017 +0000 ---------------------------------------------------------------------- be/src/exec/kudu-util.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/676a88f3/be/src/exec/kudu-util.cc ---------------------------------------------------------------------- diff --git a/be/src/exec/kudu-util.cc b/be/src/exec/kudu-util.cc index ef1c74b..e7afb7c 100644 --- a/be/src/exec/kudu-util.cc +++ b/be/src/exec/kudu-util.cc @@ -17,6 +17,7 @@ #include "exec/kudu-util.h" +#include <algorithm> #include <string> #include <sstream> @@ -102,7 +103,8 @@ void InitKuduLogging() { DCHECK(KuduIsAvailable()); static kudu::client::KuduLoggingFunctionCallback<void*> log_cb(&LogKuduMessage, NULL); kudu::client::InstallLoggingCallback(&log_cb); - kudu::client::SetVerboseLogLevel(FLAGS_v); + // Kudu client logging is more noisy than Impala logging, log at v-1. + kudu::client::SetVerboseLogLevel(std::max(0, FLAGS_v - 1)); } } // namespace impala
